172706 - Mozilla Firebird should not try to use $MOZILLA_FIVE_HOME

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Neil Cronin]

dist/bin/phoenix is trying to launch $MOZILLA_FIVE_HOME/phoenix-bin, which is
probably not there.

Comment 1

[Neil Cronin]

Attachment: patch to search PHOENIX_HOME, not MOZILLA_FIVE_HOME

Comment 2

[Asa Dotzler [:asa]]

*** Bug 173416 has been marked as a duplicate of this bug. ***

Comment 3

[Andrew Schultz]

note that the current startup script can find the appropriate directory just
fine without any *_HOME environment variable set.  In the past, it was necessary
to use the variable if the startup script was symlinked to.  There might be a
good reason to keep such functionality with Phoenix, but I can't think of one.

The run-mozilla.sh script sets the MOZILLA_FIVE_HOME variable to the appropriate
value, which is still needed by XPCOM.

Comment 4

[Neil Cronin]

andrew, agreed.  the problem is that some systems have mozilla_five_home set, so
starting phoenix is impossible.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 101781 [details] [diff] [review]
patch to search PHOENIX_HOME, not MOZILLA_FIVE_HOME

bryner, can you review this patch please? Thanks.

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 101781 [details] [diff] [review]
patch to search PHOENIX_HOME, not MOZILLA_FIVE_HOME

This is going to break things. run-mozilla.sh sets MOZILLA_FIVE_HOME in the
environment, and XPCOM explicitly looks for the value of that environment
variable.

Comment 7

[Neil Cronin]

bryner, this doesn't change that at all.  this patch just ignores the user-set
value if there is one.  some package managers set the value of moz_five_home to
the (correct) location of mozilla.  this patch tells phoenix to ignore that,
which I think it should.  i.e., /usr/local/mozilla/phoenix-bin will NEVER exist
if you installed mozilla via portage or whatever.

also, XPCOM seems perfectly happy with this patch.

Comment 8

[Andrew Schultz]

> run-mozilla.sh sets MOZILLA_FIVE_HOME in the environment

and with the patch, it still does.  the run-mozilla.sh script overrides anything
that was set in the environment.

and again, I don't know of any useful functionality that can be gained by
looking at any *_HOME from the environment.  My vote would be to remove it from
the mozilla startup script completely.

Comment 9

[Brian Ryner (not reading)]

Comment on attachment 101781 [details] [diff] [review]
patch to search PHOENIX_HOME, not MOZILLA_FIVE_HOME

Sorry, I should have read that closer.	r=me.

Comment 10

[Neil Cronin]

especially with phoenix potentially changing its name, I agree with Andrew that
these lines should probably just be removed.

Comment 11

[Brian Ryner (not reading)]

I went ahead and just removed the environment variable check.

Comment 12

[Simon Paquet [:sipaq]]

Verified