1727072 - Popups are cropped when display is scaled

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Lyubomir [:mystiquewolf]]

As requested in https://bugzilla.mozilla.org/show_bug.cgi?id=1718507#c35 i file a new bug with the info from about:support.

Comment 1

[Lyubomir [:mystiquewolf]]

Attachment: Troubleshooting info

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Please run firefox with MOZ_LOG="WidgetPopup:5" env variable, open hamburger menu (cropped) and attach the log here.
Also which screen resolution do you use?
Thanks.

Comment 3

[Lyubomir [:mystiquewolf]]

Attachment: moz_log.txt

Comment 4

[Lyubomir [:mystiquewolf]]

Operating System: Kubuntu 21.04
KDE Plasma Version: 5.22.4
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.2
Kernel Version: 5.11.0-25-lowlatency (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i5-8250U CPU @ 1.60GHz
Memory: 7,6 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Which screen resolution do you use? Is the 1536x864 correct one?

Comment 6

[Lyubomir [:mystiquewolf]]

Attachment: Screenshot_20210823_174857.png

The display of the laptop is 1920x1080. When the scale is set to 1 KDE shows 1920x1080 in Display Configuration Settings. When the scale is set to 1.25 KDE shows 1536x864 in Display Configuration Settings.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Please try latest nightly under Wayland:
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems?rd=Bug_info_Firefox#Testing_Mozilla_binaries
Thanks.

Comment 8

[Lyubomir [:mystiquewolf]]

Yay, on latest Nightly it works.

I'll now post screenshots of some bugs which i believe are out of scope for this specific bug but are related from a user point of view. I also believe that they have a large chance of already being reported?

Comment 9

[Lyubomir [:mystiquewolf]]

Attachment: Firefox context menu.png

Context menu frequently appears like this.

Comment 10

[Lyubomir [:mystiquewolf]]

Attachment: Firefox context menu 3.png

But somehow it appears on top of cursor - normal/okay.

Comment 11

[Lyubomir [:mystiquewolf]]

Attachment: Firefox context menu 2.png

Above cases happen when you click towards the button of the viewport with little space below it for the context menu to appear.

This last case is what happens when i click somewhere to the top - it shows the scrollbar even then, so maybe its erratic behavior between two ways of working - one which tries to position the context menu inside the viewport and therefore generates scroll arrow; and another one, which doesn't care about the viewport and if it happens it also draws part of the context menu over the address bar so that it doesn't produce a scroll arrow. This is all speculation from myself.

Comment 12

[Lyubomir [:mystiquewolf]]

In Comment #10 please read "somewhere" instead of "somehow".

Comment 13

[Lyubomir [:mystiquewolf]]

Err, i mean, please read "Sometimes". I guess i need some rest.

Comment 14

[Lyubomir [:mystiquewolf]]

And in Comment #11 please read "when you click towards the bottom" instead of "towards the button".

Comment 15

[Lyubomir [:mystiquewolf]]

Attachment: Firefox list tabs issue.png

Also this switcher is not centered, although it is a positive progress over the previous state of being which was all tabs squashed up and overlapping.

Comment 16

[Martin Stránský [:stransky] (ni? me)]

Well, the popup position/size depends on compositor, we get such window size from mutter so we can't fiddle with that.
Please file the bug from https://bugzilla.mozilla.org/show_bug.cgi?id=1727072#c14 as a new bug, that may be caused by wrong screen sizes.
Thanks.

Comment 17

[Lyubomir [:mystiquewolf]]

• Shouldn't this bug be RESOLVED -> FIXED by you?
• I've filed bug Bug 1729944 as requested.

• Well, the popup position/size depends on compositor, we get such window size from mutter so we can't fiddle with that.

  • I think you're talking about the tab switcher not being centered, are you? If so, do you think filing a bug with KDE could help?

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Please file a bug for 'switcher is not centered'. The popup position is out of our control so Bug 1729944 can be fixed as wontfix.

Comment 19

[Martin Stránský [:stransky] (ni? me)]

Tab switcher is rendered by Firefox so we have some control over it.

Comment 20

[Martin Stránský [:stransky] (ni? me)]

[Tracking Requested - why for this release]:

Comment 21

[Lyubomir [:mystiquewolf]]

Filed https://bugs.kde.org/show_bug.cgi?id=442304

Comment 22

[Vlad Zahorodnii [:zzag]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #18)

Please file a bug for 'switcher is not centered'. The popup position is out of our control so Bug 1729944 can be fixed as wontfix.

Firefox sets the following xdg-positioner constraint adjustments: slide_x, flip_x, flip_y, resize_x, and resize_y. If a popup can't be flipped vertically, the only thing that's left is to resize the popup (SLIDE_Y is not set). It's not a compositor bug, firefox needs to set appropriate constraint adjustments.

Comment 23

[Lyubomir [:mystiquewolf]]

FWIW i've also filed Bug 1730332

Comment 24

[Lyubomir [:mystiquewolf]]

• Reopening this bug was a mistake. It should be again closed as RESOLVED FIXED. I don't have privileges to do that but promptly needinfo-ing @Martin Stransky.

To summarize:

• This bug is about cropped popups on KDE/KWin due to KDE/KWin resolution and display scaling - this was fixed.
• Inside this bug there are two related issues mentioned, each of which have a separate bug:
  • Tab Switcher (Ctrl + Tab) is not centered on KDE Wayland when "Display Scaling" is used - Bug 1730332, which i recently closed as i found out it works on latest Nightly. Will reopen if issue returns.
  • Firefox context menu is small and displays with scrollbar on KDE Wayland - Bug 1729944, which i should have reopened instead of this bug. The new info in Comment #22 applies only to that related bug.

Comment 25

[Martin Stránský [:stransky] (ni? me)]

Okay, let's move rest to Bug 1729944 then.