Closed Bug 1727197 Opened 2 months ago Closed 2 months ago

"Show All" label doesn't appear when on the last page of synced tabs

Categories

(Firefox :: Toolbars and Customization, defect, P3)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: mtigley, Assigned: kpatenio)

Details

Attachments

(1 file)

Follow-up to Bug 1625478. It looks like these attributes aren't being used anywhere and we should just remove them: https://searchfox.org/mozilla-central/rev/4cca5d2f257c6f1bcef50a0debcbd66524add703/browser/base/content/appmenu-viewcache.inc.xhtml#606-607

EDIT: It looks like these labels are supposed to be used, according to: https://searchfox.org/mozilla-central/source/browser/base/content/browser-sync.js#235-236,243

Severity: -- → S3
Priority: -- → P3
Type: task → defect
Summary: Remove "showAllLabel" and "showAllTooltipText" → "Show All" label doesn't appear when on the last page of synced tabs
Assignee: nobody → kpatenio
Status: NEW → ASSIGNED

According to this bugzilla task and this commit that added the "show more" and "show all" buttons, both buttons were used at the same time.

A commit for Proton modified the showAllLabel and showAllTooltipText attributes.
Got in contact @mconley and @emalyz for more info to see if this change was intentional.

Update: "show all" button was meant to be removed. Will delete any "show all" fluent strings .

Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a9e3925fb22
Remove fluent strings for synced tabs "show all" button. r=emalysz
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.