1727227 - Add a static assert to ensure the size of the value variant in AccAttributes isn't unintentionally changed

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P1)

Description

[James Teh [:Jamie] (away returning 28 Jan)]

AccAttributes uses a Variant to store values. In a 64 bit build, that currently consumes 16 bytes. (I need to check the size on 32 bit.) Given the number of attributes we'll be storing for RemoteAccessibles, ideally, we don't want that to increase. If we have to increase it, we should be very deliberate and informed about that decision. Adding a static assert will help ensure this.

Comment 1

[James Teh [:Jamie] (away returning 28 Jan)]

Attachment: Bug 1727227: Add a static assert to ensure that the size of the AccAttributes value variant isn't unintentionally changed.

Comment 2

[James Teh [:Jamie] (away returning 28 Jan)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0db403c779931a30baa0bdde2cf4b14cff12b49c

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6d235714a43c