1727267 - Some passwords gone

Status: RESOLVED DUPLICATE of bug 702925

(Toolkit :: Password Manager, defect)

Description

[vasileios.revelas]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

I connect to various intranet domains ending with a .plc suffix, and had saved at least three passwords for them. On 2021-08-23 I noticed saved passwords for domains ending in .plc had disappeared. All my other saved logins are still there, including other intranet sites ending non-standard suffixes like .local and .remote.

I'm not sure if this is related, but on the same day I upgraded from version 91.0+build2-0ubuntu0.18.04.1 to version 91.0.1+build1-0ubuntu0.18.04.1 while Firefox was running. I was prompted to restart Firefox with a "We just need to do one more thing" page, which I did. It was shortly after that when I tried to log in to an intranet site and noticed the password was no longer saved. The timing could just be a coincidence though.

I do use Sync. I'm a developer and will be happy to check logs or sync history (if such a thing exists) if someone can point me in the right direction.

Actual results:

I was unable to log in to various intranet sites whose domain ends with .plc as my password was no longer saved.

Expected results:

The saved logins should not have disappeared.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Password Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Tim Giles [:tgiles]]

Thanks for filing this Vasileios, losing your passwords/logins is the absolute last thing we want! Do you happen to remember the timing when this issue occurred? Did you have these .plc passwords saved before 2021-08-23, or did you recently enter them before the upgrade happened? My guess is that there may have been an interrupt in the disk I/O when Firefox upgraded and so your changes didn't get committed to memory (which, if my guess is correct, is not good).

I'm not too familiar with the Linux side of things, so how do you have your Firefox installed on your machine? Might be relevant for tracking this down.

You said you use Sync, did re-syncing after you noticed the passwords for .plc were gone restore those passwords?

If you're able to reproduce the issue (i.e. create logins but they don't save), you can follow this guide on how to enable debug logging for password manager and how to attach logs to bugs to help us out.

Comment 3

[vasileios.revelas]

Hi Tim, I was able to remember the lost passwords so no harm was done luckily. I'd had the passwords that were lost saved for over a year prior to their disappearance on 2021-08-23. I hadn't made any changes to them around that date.

I have Firefox installed using Ubuntu Linux's official package for Ubuntu 18.04, so installing it is a matter of running "apt install firefox" on an Ubuntu 18.04 installation.

I did try re-syncing but that didn't restore the passwords. Do you know if there's any sort of sync log that could confirm the day/time they were removed?

Unfortunately I haven't been able to reproduce the issue. I did try and downgrade to the previous version (91.0+build2-0ubuntu0.18.04.1) to try upgrade again and see if the issue repeats itself, but unfortunately it isn't available in the Ubuntu package repositories any more (I checked here: http://archive.ubuntu.com/ubuntu/pool/main/f/firefox/).

Comment 4

[Tim Giles [:tgiles]]

Hey Vasileios, I'm going to go ahead and close this bug as "worksforme" since we're unable to reproduce. If you happen to stumble upon this issue again, here's some items to check out that should help us diagnose what is going on with the bug.

1. Check the login store to see if the logins are still present in memory but are not visually showing up in about:logins. Sometimes logins will become corrupted (for example, if you use primary password to encrypt some old logins, but then copy your old profile into a new Firefox without using the previous primary password...since we don't have the old key, we can't decrypt those older logins and then we won't show them in about logins). You can check the login store by calling await Services.logins.getAllLoginsAsync() in your browser console. This will print out the stored logins in your browser console, so please do not attach this particular log if you reopen/refile this bug! It will be beneficial to know if the missing logins show up in this call however, since if they are corrupted in some way these logins will not show up in the resulting array.

2. Check your logins.json and logins-backup.json in your profile. You can discover your profile folder by navigating to about:support and then looking for "Profile Folder". Check to see if the missing logins are in these files and let us know if the logins are in logins.json and/or logins-backup.json.

Comment 6

[vasileios.revelas]

Turns out this was because I had used "Forget about this site" when right clicking an entry in the history menu. There is already a bug open for this so I've marked this as a duplicate now.