1727302 - Add onsecuritypolicyviolation event handler

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Sonia Singla :soniasingla]

See: https://github.com/whatwg/html/pull/2651

Webkit started on adding it, it would be nice to have it in firefox too.

Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=229381

Comment 1

[Sonia Singla :soniasingla]

I am working on it

Comment 2

[Sonia Singla :soniasingla]

Attachment: Bug 1727302 - Add onsecuritypolicyviolation event handler.r?smaug

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7459f43c367
Add onsecuritypolicyviolation event handler.r=smaug

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e7459f43c367

Comment 5

[Hamish Willee]

I'm adding docs for this in FF93, which you can track in https://github.com/mdn/content/issues/8614

From what I can see, and basic testing, this adds a global onsecuritypolicyviolation event handler. I think this means that you can now use onsecuritypolicyviolation on window or document or any other element. Before this change on Firefox you couldn't use onsecuritypolicyviolation at all (though you could use addEventListener on document or Window). Is that about right?

The spec says "The following event handler content attributes may be specified on any HTML element:". However I wrote some test code and found that a handler added to <p> or <img> using onsecuritypolicyviolation does not seem to be fired - while it is for Document or Window. My test shows that the method is not undefined (using typeof) so presumably it exists.

Perhaps this is because of the nature of the API. If you add the handler before the HTML is loaded (before a violation) presumably the element is null - and so you won't be able to add the handler. If you add a script after HTML has loaded the violation has already occurred, so you won't see the event at all. In other words it feels like even though you can add this to elements, you will never actually see it fired if you do. Does that make sense?

Is there any more "specialness" to this?

Comment 6

[Frédéric Wang (:fredw)]

@Hamish Are you able to get the handler fired if you register it on <p> or <img> via addEventListener instead of an onsecuritypolicyviolation IDL/content attribute?

Comment 7

[Hamish Willee]

@fredw No.

Note that if load scripts before the HTML has loaded the p and img are null - so that fails. If I add after they have loaded the event has already been fired so I don't get the handler called. I guess it works for the window because that exists before the event fires

Comment 8

[Frédéric Wang (:fredw)]

@Hamish: OK, i guess that's expected then. The new attributes should behave the same as addEventListener. (note that WPT tests just use rely on EventTarget.dispatchEvent to emulate an event).

Comment 9

[Hamish Willee]

I guess it is. Though it feels a bit odd, and of course I worry my test code is wrong. I'll add a note in the docs to highlight the case.

Comment 10

[Hamish Willee]

FYI work for this is essentially complete, though will be going through review. You can track in https://github.com/mdn/content/issues/8614#issuecomment-913969124. I have added dev-doc-complete.

Thank you for your help Frédéric.