1727392 - Send Firefox Suggest Nimbus exposure ping when a Firefox Suggest result is shown

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Currently we send the exposure ping when the user is simply enrolled in the feature. We want to change that to sending it when the first Firefox Suggest result is shown. Unlike the current keyed-scalar impression telemetry, the user doesn't need to complete an engagement with the urlbar; we want to record the exposure simply if a result is shown and without any other conditions.

https://mozilla-hub.atlassian.net/browse/SNT-23

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1727392 - Send Firefox Suggest Nimbus exposure ping when a Firefox Suggest result is shown.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b470ebce6382cff8fdd07184e67cd9c7de7f628

Comment 3

[Nan Jiang [:nanj]]

[Tracking Requested - why for this release]: this patch will facilitate the experiment analysis for Firefox Suggest.

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=22c98def50d6d6102077dd02299b300343cd4751

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/492f4548e595

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 93.0a1 (Build ID: 20210825095400) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20.

• The "expose" event is correctly triggered once per session when a sponsored result is displayed.

Comment 7

[Nan Jiang [:nanj]]

Comment on attachment 9237788 [details]
Bug 1727392 - Send Firefox Suggest Nimbus exposure ping when a Firefox Suggest result is shown.

Beta/Release Uplift Approval Request

• User impact if declined: This allows us to understand how many users are "exposed" to the feature for Firefox Suggest Nimbus experiments.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only slightly tweaks when we trigger the Nimbus "exposure" event for the Firefox Suggest experiments, it has no effect on any user-facing features.
• String changes made/needed: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237788 [details]
Bug 1727392 - Send Firefox Suggest Nimbus exposure ping when a Firefox Suggest result is shown.

Approved for 92.0b9.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cede4f4bd210

Comment 10

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 92.0b9 (Build ID: 20210826192006) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20.

• The "expose" event is correctly triggered once per session when a sponsored result is displayed.