Closed Bug 1727397 Opened 4 years ago Closed 4 years ago

Unicode characters (e.g. 𝑮) may cause oversized tab-strip and history tooltips

Categories

(Firefox :: Tabbed Browser, defect)

Firefox 91
Desktop
Linux
defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: tony, Assigned: jfkthame)

References

Details

Attachments

(4 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Visited a page with the title "#𝑮eneral-chat"

Typed "eneral" to bring up the page in the address bar suggestions

Actual results:

Address bar suggestion is triple height

(Prior to the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1704404, the tab bar was also triple height. 91.0.1 fixed the tab bar, but not the address bar suggestions.

Expected results:

The address bar should be the same height as other suggestions

You can verify this by opening this ticket and then searching for "1727397" in your address bar suggestions. Since the character in question is in the title of the bug (and therefore the page), this ticket page presents the problem.

Also you can verify on the tab tooltip for this bugzilla ticket that the tooltip is also double height.

Also affected is the history tooltip

Attachment #9237801 - Attachment description: image.png → Oversized history tooltip
Attachment #9237801 - Attachment filename: image.png → oversized-history-tooltip.png
See Also: → 1704404

Address-bar suggestions are covered by bug 1671525, fixed in Firefox 92.

Tooltips were also mentioned in bug 1719436, which was closed as a duplicate but were not in fact fixed by bug 1671525. So I'm updating the summary of this bug to be specific to tooltips as that's the (main?) remaining issue.

Summary: Unicode characters (e.g. 𝑮) cause oversized address bar suggestions → Unicode characters (e.g. 𝑮) may cause oversized tab-strip and history tooltips
Status: UNCONFIRMED → NEW
Ever confirmed: true

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Address Bar

The address bar is just setting the title attribute on <html:span>s, and I imagine the tab overflow menu is doing the same, so this doesn't need to be in the Address Bar component. I don't know whether this belongs in Layout, DOM, or Widget, but over to Widget: Gtk for further triage.

Component: Address Bar → Widget: Gtk
OS: Unspecified → Linux
Product: Firefox → Core
Hardware: Unspecified → Desktop
Component: Widget: Gtk → Tabbed Browser
Product: Core → Firefox

This seems similar to other bugs that Jonathan has recently fixed.

Flags: needinfo?(jfkthame)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #9238403 - Attachment description: Bug 1727397 - Specify an explicit ine-height for tooltips on Linux. r=jaws → Bug 1727397 - Specify an explicit line-height for tooltips on Linux. r=jaws
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28bbc73265d5 Specify an explicit line-height for tooltips on Linux. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Flags: needinfo?(jfkthame)
Regressions: 1741263
Regressions: 1773891
Regressions: 1840645
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: