1727475 - [rust 1.55] error: unused borrow that must be used

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Mike Hommey [:glandium]]

Building with rustc 1.55 beta 7 fails with

[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -     --> intl/encoding_glue/src/lib.rs:366:9
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -      |
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -  366 | /         &mut (handle.as_mut_slice())[..already_validated]
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -  367 | |             .copy_from_slice(&bytes[..already_validated]);
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -      | |_________________________________________________________^
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -      |
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -      = note: `-D unused-must-use` implied by `-D warnings`
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -  error: unused borrow that must be used
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -     --> intl/encoding_glue/src/lib.rs:543:9
[task 2021-08-25T05:46:08.008Z] 05:46:08     INFO -      |
[task 2021-08-25T05:46:08.009Z] 05:46:08     INFO -  543 |         &mut (handle.as_mut_slice())[..valid_up_to].copy_from_slice(&bytes[..valid_up_to]);
[task 2021-08-25T05:46:08.009Z] 05:46:08     INFO -      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2021-08-25T05:46:08.009Z] 05:46:08     INFO -  error: could not compile `encoding_glue` due to 2 previous errors

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1727475 - Remove unused mut borrow.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/760b42a1ddf5
Remove unused mut borrow. r=hsivonen

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/760b42a1ddf5