1727514 - MP3 file playbacks in the background even if the page is closed

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: mp3 playback still going.gif

Affected versions

• Firefox 92.0b8 msix
• Firefox 93.0a1 msix

Affected platforms

• Windows 11

Steps to reproduce

1. Launch Firefox
2. Access this page
3. Click on Download for any MP3 file
4. The file autoplays in a new page
5. Click on "Go Back" from the toolbar to get to the page from step 2

Expected result

• The file stops playing

Actual result

• The file still plays in the background and the only way to stop it is to close the tab

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the attachment.
• Sometimes the playback will stop but when going forward to the "next page" again, the song will continue where it stopped and won't reset itself to 0:00.
• There are times when starting Firefox with the same profile and if accessing the page from step 2, the song will automatically start playing randomly.
• I wasn't able to reproduce the initial issue on normal builds, only the behavior from the second additional note.

Comment 1

[Alice0775 White]

I can reproduce the issue in Nightly93.0a1 Windows10 if Fission is enabled.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ab936b7f0c9f9e0b27e42e3f7909131bface08b9&tochange=7d32671931b7c2f5cb24b0f4d62bb6884e484175

Comment 2

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Doesn't seem to relate to MSIX.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1727514 - media playback should stop in the bfcache, r=peterv

SetContainer handling is similar to what DocumentViewer does for the old bfcache implementation.
(The old implementation hides it quite well).
The changes to HTMLMediaElement are needed to ensure page can enter bfcache.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d49d73f38aa
media playback should stop in the bfcache, r=peterv

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2d49d73f38aa

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing frequent crashes

Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80a83d69906f
media playback should stop in the bfcache, r=peterv

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/80a83d69906f

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 93.0a1 (20210825214919) on Windows 10x64 while having fission.autostart:true.
Verified fixed with Firefox 94.0b9 on Windows 10x64, 11x64, macOS 11.6, and Ubuntu 21.04. The song is no longer playing if fission.autostart:true and following STR from comment 0.