Closed Bug 1727563 Opened 2 years ago Closed 2 years ago

Implement TryLock methods and RAII class helpers for RWLock

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(1 file)

Bug 1727563 - Implement TryLock methods and RAII helpers for RWLock. r?#xpcom-reviewers
48 bytes, text/x-phabricator-request
Details | Review

See D123227 for where these are useful.

TL;DR to avoid blocking the real-time audio thread in webrtc while main thread is using a lock for a read (writes happen on a third thread) that is not during renegotiation.

Assignee: nobody → apehrson
Status: NEW → ASSIGNED
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/38c2002963c9
Implement TryLock methods and RAII helpers for RWLock. r=xpcom-reviewers,nika

Backed out causing gtest crashes on RWLock
Backout link
Push with failures
Failure Log

Flags: needinfo?(apehrson)
Flags: needinfo?(apehrson)
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4b81507e0ac3
Implement TryLock methods and RAII helpers for RWLock. r=xpcom-reviewers,nika

https://hg.mozilla.org/mozilla-central/rev/4b81507e0ac3

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.