1727598 - audio is cut when using external input and output device

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[C.M.Chang[:chunmin]]

Attachment: firefox-logs.child-9.moz_log

Got this report from matrix. The audio is cut when using the external input and output device. Here is the log

Comment 1

[C.M.Chang[:chunmin]]

Attachment: about-support.json

Here is the about-support

Comment 2

[C.M.Chang[:chunmin]]

Attachment: GitHub Pull Request

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1721496

Comment 4

[Ryan VanderMeulen [:RyanVM]]

It's probably too late to get this fixed in time for the 92.0 release given that we're already at RC week, but leaving this fix-optional as a possible ride-along in case the fix is an easy uplift.

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1727598 - Update cubeb-coreaudio-rs to 4ee3b2831. r?#cubeb-reviewers

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1727598 - mach vendor rust. r?#cubeb-reviewers

Comment 7

[Paul Adenot (:padenot)]

It is a trivial uplift. We'll want to take this, this makes any WebRTC app unusable for some macOS users.

We know one configuration that can reproduce, but we don't know how many configurations can reproduce.

Comment 8

[Paul Adenot (:padenot)]

Also, this has been verified by the reporter and :chunmin who wrote the patch.

Comment 9

[Paul Adenot (:padenot)]

I'm landing this now, this has been reviewed upstream. Try is green: https://treeherder.mozilla.org/jobs?repo=try&revision=55ae323c16dbf4d8e38b9b872ed003aea77fadd5.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e7efd219c6f
Update cubeb-coreaudio-rs to 4ee3b2831.
https://hg.mozilla.org/integration/autoland/rev/ac0a7b68008f
mach vendor rust.

Comment 11

[Paul Adenot (:padenot)]

Adjusting severity based on comment 7.

Comment 12

[Paul Adenot (:padenot)]

Attachment: WIP: Bug 1727598 - Restore audio input handling behaviour from 91 for beta.

Comment 13

[Paul Adenot (:padenot)]

Comment on attachment 9238516 [details]
WIP: Bug 1727598 - Restore audio input handling behaviour from 91 for beta.

Beta/Release Uplift Approval Request

• User impact if declined: This fixes audio input (microphone) for macOS users using external audio devices.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This restores the behavior of 91 (current release). This has been independently reproduced and subsequently verified by two people with different configuration. It's the same patch that landed on central, rebased for beta.
• String changes made/needed: none

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9238516 [details]
WIP: Bug 1727598 - Restore audio input handling behaviour from 91 for beta.

Approved for 92.0rc1.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/132acb8466da
https://hg.mozilla.org/releases/mozilla-beta/rev/ca7af01d0eba

Comment 16

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1e7efd219c6f
https://hg.mozilla.org/mozilla-central/rev/ac0a7b68008f

Comment 18

[Daniel Bodea [:danibodea]]

Considering the added "qe-verify+" tag, we have attempted reproducing this issue on Mac OS 10.14 (originally affected system) and Mac OS 11, with Nightly v93.0a1 from 29th and 30th of August, on Beta v92b9, v92.0b5 and others.
We've tried interrupt tests (connecting/disconnecting different audio devices from the system) with TTRS headsets, USB Headsets while playing different audio-video streaming applications (like youtube and webrtc).

We could not reproduce the audio being cut issue. More information on how this issue was initially reproduced is necessary.
C.M.Chang, can you help us with the necessary information? Thanks!

Comment 19

[C.M.Chang[:chunmin]]

I reproduced the situation on my end with an external sound card configured to a 4-channel output (it's a 7.1 external USB soundcard) and an external camera that has a built-in mic as input.

I tested the sound by https://webrtc.github.io/samples/src/content/getusermedia/audio/.

The sound was on and off in the broken version (FF92). The audio was cut constantly.

Step to reproduce

0. Prepare a broken version of Firefox, which is a version without the patches here
   • Note that we've uplifted to FF 92 as well
   • A nightly build in 08-25-2021 might be a good candidate, or other FF92 versions before we uplifted
1. Connect an external USB soundcard and set it as the default output device
2. Connect an external USB microphone (and choose it as the input device later)
3. Go to https://webrtc.github.io/samples/src/content/getusermedia/audio/, and select the external USB microphone as the input device
4. Making some voice and play it out from the external USB soundcard (it should be the default output device now)
   • The sound played out should be cut constantly, or sounds stuttering

If the issue can be reproduced, please re-try the above steps in the current Firefox Nightly version to see if the issue is fixed. Feel free to let me know if you need my help. Thanks!

Comment 20

[Daniel Bodea [:danibodea]]

Unfortunately, I do not have an external sound card and a USB microphone to reproduce this issue and verify the fix.
Will you be so kind as to help up and verify the fix in the fixed channels?

1. Firefox v92.0 Release Candidate for mac
2. Nightly v93.0a1 for mac

Thank you for your contribution!

Comment 21

[C.M.Chang[:chunmin]]

(In reply to Bodea Daniel [:danibodea] from comment #20)

1. Firefox v92.0 Release Candidate for mac
2. Nightly v93.0a1 for mac

The audio input works well on my end and the current nightly build

Comment 22

[Brindusa Tot, Desktop QA]

This is already in release and based on latest comment this is fixed.