Closed Bug 1727653 Opened 3 years ago Closed 2 years ago

Intermittent toolkit/content/tests/chrome/test_navigate_persist.html | Window width is persisted - got 136, expected 200

Categories

(Toolkit :: UI Widgets, defect, P5)

defect

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox-esr91 --- fixed
firefox102 --- fixed
firefox103 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: karlt)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file)

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=349591466&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SmMnCOkwRHWgPezEO-hECg/runs/0/artifacts/public/logs/live_backing.log


[task 2021-08-25T23:40:16.029Z] 23:40:16     INFO - TEST-START | toolkit/content/tests/chrome/test_navigate_persist.html
[task 2021-08-25T23:40:16.136Z] 23:40:16     INFO - TEST-INFO | started process screenshot
[task 2021-08-25T23:40:16.225Z] 23:40:16     INFO - TEST-INFO | screenshot: exit 0
[task 2021-08-25T23:40:16.234Z] 23:40:16     INFO - Buffered messages logged at 23:40:16
[task 2021-08-25T23:40:16.234Z] 23:40:16     INFO - must wait for load
[task 2021-08-25T23:40:16.235Z] 23:40:16     INFO - must wait for focus
[task 2021-08-25T23:40:16.235Z] 23:40:16     INFO - TEST-PASS | toolkit/content/tests/chrome/test_navigate_persist.html | Window is resized to desired width 
[task 2021-08-25T23:40:16.236Z] 23:40:16     INFO - TEST-PASS | toolkit/content/tests/chrome/test_navigate_persist.html | Window is resized to desired height 
[task 2021-08-25T23:40:16.236Z] 23:40:16     INFO - must wait for load
[task 2021-08-25T23:40:16.236Z] 23:40:16     INFO - must wait for focus
[task 2021-08-25T23:40:16.237Z] 23:40:16     INFO - TEST-PASS | toolkit/content/tests/chrome/test_navigate_persist.html | Initial window width is not the persisted size 
[task 2021-08-25T23:40:16.237Z] 23:40:16     INFO - TEST-PASS | toolkit/content/tests/chrome/test_navigate_persist.html | Initial window height is not the persisted size 
[task 2021-08-25T23:40:16.238Z] 23:40:16     INFO - Buffered messages finished
[task 2021-08-25T23:40:16.238Z] 23:40:16     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_navigate_persist.html | Window width is persisted - got 136, expected 200
[task 2021-08-25T23:40:16.238Z] 23:40:16     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:500:14
[task 2021-08-25T23:40:16.239Z] 23:40:16     INFO - runTest@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_navigate_persist.html:63:9
[task 2021-08-25T23:40:16.239Z] 23:40:16     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-08-25T23:40:16.240Z] 23:40:16     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_navigate_persist.html | Window height is persisted - got 47, expected 200
[task 2021-08-25T23:40:16.240Z] 23:40:16     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:500:14
[task 2021-08-25T23:40:16.240Z] 23:40:16     INFO - runTest@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_navigate_persist.html:64:9
[task 2021-08-25T23:40:16.240Z] 23:40:16     INFO - GECKO(8900) | MEMORY STAT | vsize 2112828MB | vsizeMaxContiguous 66692484MB | residentFast 376MB | heapAllocated 227MB
[task 2021-08-25T23:40:16.241Z] 23:40:16     INFO - TEST-OK | toolkit/content/tests/chrome/test_navigate_persist.html | took 144ms
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

Update:
There have been 60 failures within the last 7 days:

  • 20 failures on Linux 18.04 x64 WebRender Shippable opt
  • 39 failures on Linux 18.04 x64 WebRender opt/debug
  • 1 failure on Linux 18.04 x64 WebRender asan opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=381052079&repo=autoland&lineNumber=5515

Karl, based on comment 25 , is there any chance you could take a look at this?
Thank you.

Flags: needinfo?(karlt)

Some "Widget" logging is at https://treeherder.mozilla.org/logviewer?job_id=381240304&repo=try&lineNumber=17084

The test was waiting for DOMContentLoaded before checking the window dimensions, but persisted sizes are not requested until BeforeStartLayout().

The test will need to wait for the async resize to complete.

Assignee: nobody → karlt
Flags: needinfo?(karlt)
See Also: → CVE-2022-34479
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6dfa7aade8b
wait for resize event before testing restoration of persisted sizes r=niklas

Comment on attachment 9281318 [details]
Bug 1727653 wait for resize event before testing restoration of persisted sizes r?niklas

Beta/Release Uplift Approval Request

  • User impact if declined: Frequent intermittent test failure.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Test-only change.
  • String changes made/needed: None.
  • Is Android affected?: No
Attachment #9281318 - Flags: approval-mozilla-beta?
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

Comment on attachment 9281318 [details]
Bug 1727653 wait for resize event before testing restoration of persisted sizes r?niklas

Approved for 102 beta 9, thanks.

Attachment #9281318 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9281318 [details]
Bug 1727653 wait for resize event before testing restoration of persisted sizes r?niklas

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Frequent intermittent test failure after uplift for bug 1745595.
  • User impact if declined: Test-only change.
  • Fix Landed on Version: 103
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Test-only change.
Attachment #9281318 - Flags: approval-mozilla-esr91?
Attachment #9281318 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: