Closed
Bug 1727710
Opened 3 years ago
Closed 3 years ago
Rename enum value DirPaddingFile::FILE in dom/cache/FileUtils.h
Categories
(Core :: Storage: Cache API, task, P3)
Core
Storage: Cache API
Tracking
()
RESOLVED
FIXED
93 Branch
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: jjalkanen, Assigned: hxu)
Details
Attachments
(1 file)
Enumerator value DirPaddingFile::FILE in dom/cache/FileUtils.h is confused with the typename FILE from stdio.h by some compilers and code indexers while working in dom::cache namespace.
To avoid this, the DirPaddingFile::FILE should be renamed along with its usages, see files in https://searchfox.org/mozilla-central/search?q=DirPaddingFile&path=&case=true®exp=false
|
||
Comment 1•3 years ago
|
||
Maybe just change it to an enum class.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → hxu
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9239110 -
Attachment description: Bug 1727710 - Change DirPaddingFile to enum class. r=janv, a=RyanVM → Bug 1727710 - Change DirPaddingFile enum to enum class; r=#dom-storage
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d1a0ffd026c Change DirPaddingFile enum to enum class; r=janv,dom-storage-reviewers
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•