1727715 - Mispositioned header in gitlab.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

File header in https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/31/diffs#diff-content-69153454dc41136bd2d5cba70a39f8bf20402947 hit-test at the right place but is painted shifted down.

Comment 1

[Darkspirit]

mozregression --good 2021-02-01 --bad 2021-08-26 --pref gfx.webrender.all:true -a 'https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/31/diffs#diff-content-69153454dc41136bd2d5cba70a39f8bf20402947'

7:46.75 INFO: Last good revision: e0309c1ae0fe14ab9a30270fce542cfd4de08849
7:46.75 INFO: First bad revision: 1d332a5ff4f9e19bbd54e3b9c2f5d84f3d2b8bc7
7:46.75 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e0309c1ae0fe14ab9a30270fce542cfd4de08849&tochange=1d332a5ff4f9e19bbd54e3b9c2f5d84f3d2b8bc7

1d332a5ff4f9e19bbd54e3b9c2f5d84f3d2b8bc7 Glenn Watson — Bug 1724846 - Split DL spatial tree to separate payload r=gfx-reviewers,nical

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Thank you!

Comment 4

[Irvin (MozTW)]

confirmed the issue and the same regression result ([e0309c1a, 1d332a5f]),

screen recording of the issue: https://gitlab.com/gitlab-org/gitlab/uploads/bf90accf505e2441d948c94119316ce6/gitlab_bug.mov

On any MR at Gitlab, the file title bar on "Changes" tab covered the content.
The title moves along scrolling and always covers the center of the file content.

The bug had been reported to Gitlab at here, https://gitlab.com/gitlab-org/gitlab/-/issues/339430

Steps to reproduce:

• go to any MR that had multiple files change (eg., https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68891/diffs or any MR with longer diff)
• the title bar is misposition and covered the content.
• scroll down to see the title bar moving and keep covering the content

Comment 5

[Irvin (MozTW)]

Attachment: the mislocate title bar

Comment 6

[Glenn Watson [:gw]]

I've had the regressing patch backed out for now, since I won't be able to investigate this until next week.

Comment 7

[Darkspirit]

Fixed by backout.