1727989 - Fix JS strict warnings in unescapeTagValue

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Ian Neal]

In Bug 1724584 unescapeTagValue was introduced but it generates a strict JS warning so that should be fixed. Whilst here let's make it neater.

Comment 1

[Ian Neal]

Attachment: 1727989-irc-unescape-strict-25310.patch

[Approval Request Comment]
Regression caused by (bug #): 1724584
User impact if declined: strict JS errors
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9238400 [details] [diff] [review]
1727989-irc-unescape-strict-25310.patch

LGTM

NIT: There is a next method used in generators. I dislike having language elements mixed up with own definitions. Could you rename at least next to something else. Maybe nextData. current is ok but also sounds ambiguous. Maybe currentData?

r/a+ with this fixed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/763306b2198f
Fix JS strict warnings in unescapeTagValue. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/311fe1966318e9b68d6592289a26b45e765b6fd7
Fix JS strict warnings in unescapeTagValue. r=frg a=frg