Closed
Bug 1727992
Opened 3 years ago
Closed 3 years ago
Fix JS strict warning in addHistory in cZ static.js
Categories
(SeaMonkey :: Chat, defect)
SeaMonkey
Chat
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
seamonkey 2.92
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.10)
Attachments
(1 file)
|
3.04 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
There is a JS strict warning about undeclared samePrefix. Whilst here do some tidy up.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: JS strict warnings
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9238402 -
Flags: review?(frgrahl)
Attachment #9238402 -
Flags: approval-comm-release?
Attachment #9238402 -
Flags: approval-comm-esr60?
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9238402 [details] [diff] [review]
1727992-irc-addhistory-strict-25310.patch
LGTM
Attachment #9238402 -
Flags: review?(frgrahl)
Attachment #9238402 -
Flags: review+
Attachment #9238402 -
Flags: approval-comm-release?
Attachment #9238402 -
Flags: approval-comm-release+
Attachment #9238402 -
Flags: approval-comm-esr60?
Attachment #9238402 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0a44e3271fdd
Fix JS strict warning in addHistory in CZ static.js. r=frg
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
|
|
||
Updated•3 years ago
|
status-seamonkey2.53:
--- → affected
tracking-seamonkey2.53:
--- → ?
Summary: Fix JS strict warning in addHistory in CZ static.js → Fix JS strict warning in addHistory in cZ static.js
Whiteboard: SM2.53.10
Target Milestone: --- → seamonkey 2.92
|
|
||
Comment 4•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b97b5417a613807e50796e429a44df402d813012
Fix JS strict warning in addHistory in cZ static.js. r=frg a=frg
You need to log in
before you can comment on or make changes to this bug.
Description
•