1728017 - Searching text via context menu where text includes exclamation marks can activate DuckDuckGo's bang actions

Status: NEW

(Firefox :: Search, defect, P3)

Description

[Thomas32]

Attachment: file.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

OS: Windows 10 Home
Firefox Version: 91.0.1 & 91.0.2 (tested with both versions & reinstalled Firefox)
Firefox Nightly Version: 93.0 Alpha 1 (tested, same result)

Firefox Settings:
Default Search Engine: DuckDuckGo
Search Shortcuts: Everything removed besides DuckDuckGo, Bookmarks, Tabs, History

Today I noticed for the first time that Firefox was sometimes using Google instead of using DuckDuckgo. I mark some text on a website, right click on it and then I click in the context menu on Search DuckDuckGo for "xxx". I dont know what the issue is (maybe special characters !, ?, etc.) but sometimes Google comes up instead of DuckDuckGo when I do the above. Restarting and reinstalling Firefox didnt help.

Actual results:

Recorded my desktop (file.mp4 as attachment) so it is easier to understand what exactly happens: https://streamtape.com/v/7zAD4d8W91tA9ZW/file.mp4

Expected results:

When I set DuckDuckGo as my Default Search Engine I only want this one to use.
Dont want Google as my search at all.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Search' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alice0775 White]

STEPS

1. Open https://duckduckgo.com/
2. Type a! barbazin the search field on the page.
3. Hit Enter

Actual Results:
a! barbaz : it will be redirected to search for barbaz in amazon.
g! barbaz and ga! barbaz : it will be redirected to search for barbaz in google.
b! barbaz : it will be redirected to search for barbaz in bing.
y! barbaz : it will be redirected to search for barbaz in yahoo.
w! barbaz : it will be redirected to search for barbaz in wikipedia.

Looks like https://help.duckduckgo.com/duckduckgo-help-pages/features/bangs/ (Though a!)
So, This seems to be a feature of DuckDuckGo OR DuckDuckGo BUG.
The same thing happens in Chrome.

Comment 3

[Cristian Baica [:cbaica], Release Desktop QA]

What Alice found about the shortcuts for DDG are correct. Still our context menu search is missleading so we would need to come up with a solution for this. Setting the bug to new.

I have also managed to reproduce the issue using these steps:

1. Set DuckDuckGo as your default search engine in about:preferences#search.
2. Navigate to https://nyaa.si/view/1426854.
3. Select: "Binbougami ga!" from the top of the page.
4. Right click the selected text and choose "Search DuckDuckGo for..." option.

Expected result:
DuckDuckGo is used to search for the phrase.

Actual result:
Search is done with google.