1728037 - test_snap.js and test_snap_empty.js broken on comm-central

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

Bug 1726808 updated IsSnapEnvironment to check that the snapName matched MOZ_APP_NAME, but the tests still have "firefox" hard-wired, so they fail where MOZ_APP_NAME isn't "firefox.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1728037 - Fix test_snap.js and test_snap_empty.js when run on Thunderbird. r=Mossop,stransky

Comment 2

[Intermittent Failures Robot]

7 failures in 2580 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 7

Platform and build breakdown:

• linux64: 2
  • debug: 1
  • opt: 1
• macosx1015-64: 2
  • debug: 1
  • opt: 1
• linux64-shippable: 1
  • opt: 1
• windows10-64: 1
  • opt: 1
• macosx1015-64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1728037&startday=2021-08-23&endday=2021-08-29&tree=all

Comment 3

[Olivier Tilloy]

Ouch, sorry about that, that's a stupid oversight on my part. Thanks for the patch!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1726808

Comment 5

[Intermittent Failures Robot]

23 failures in 458 pushes (0.05 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 23

Platform and build breakdown:

• linux64: 4
  • opt: 2
  • debug: 2
• windows10-64: 2
  • opt: 2
• windows10-64-qr: 2
  • opt: 1
  • debug: 1
• linux1804-64-asan: 1
  • opt: 1
• macosx1015-64: 3
  • debug: 2
  • opt: 1
• linux64-shippable: 2
  • opt: 2
• windows7-32-qr: 4
  • opt: 2
  • debug: 2
• macosx1015-64-shippable: 2
  • opt: 2
• windows7-32-shippable-qr: 2
  • opt: 2
• windows10-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1728037&startday=2021-08-30&endday=2021-08-30&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a076d5e67c5
Fix test_snap.js and test_snap_empty.js when run on Thunderbird. r=stransky

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7a076d5e67c5

Comment 8

[Intermittent Failures Robot]

28 failures in 585 pushes (0.048 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 28

Platform and build breakdown:

• linux64: 7
  • opt: 4
  • debug: 3
• macosx1015-64: 8
  • opt: 4
  • debug: 4
• linux64-shippable: 3
  • opt: 3
• macosx1015-64-shippable: 4
  • opt: 4
• windows10-64: 2
  • opt: 2
• windows10-64-qr: 2
  • opt: 1
  • debug: 1
• windows7-32-qr: 1
  • debug: 1
• windows10-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1728037&startday=2021-08-31&endday=2021-08-31&tree=all

Comment 9

[Intermittent Failures Robot]

51 failures in 3084 pushes (0.017 failures/push) were associated with this bug in the last 7 days.

This is the #16 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 51

Platform and build breakdown:

• linux64: 11
  • opt: 6
  • debug: 5
• windows10-64: 4
  • opt: 4
• windows10-64-qr: 4
  • opt: 2
  • debug: 2
• linux1804-64-asan: 1
  • opt: 1
• macosx1015-64: 11
  • debug: 6
  • opt: 5
• linux64-shippable: 5
  • opt: 5
• windows7-32-qr: 5
  • opt: 2
  • debug: 3
• macosx1015-64-shippable: 6
  • opt: 6
• windows7-32-shippable-qr: 2
  • opt: 2
• windows10-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1728037&startday=2021-08-30&endday=2021-09-05&tree=all

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/30d3bf335961