1728070 - MarkupView is leaked from a dangling mousemove event listener

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Alexandre Poirot [:ochameau]]

The following code:
https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/inspector/markup/markup.js#342-348

    this._elt.addEventListener(
      "mousemove",
      () => {
        this._initTooltips();
      },
      { once: true }
    );

registers a mousemove listener whick leaks the MarkupView instance if no mousemove happens on this._elt. As we never try to unregister the listener on MarkupView's destroy.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1728070 - [devtools] Avoid leaking the MarkupView via a DOM event listener.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/881bdd5dcf52
[devtools] Avoid leaking the MarkupView via a DOM event listener. r=nchevobbe

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/881bdd5dcf52