Closed Bug 1728099 Opened 2 months ago Closed 1 month ago

Merge Master Passwords and Passwords pref panes into a single pref pane

Categories

(SeaMonkey :: Preferences, task)

Tracking

(seamonkey2.53? affected)

RESOLVED FIXED
seamonkey 2.90
Tracking Status
seamonkey2.53 ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

(Whiteboard: SM2.53.10)

Attachments

(1 file, 1 obsolete file)

At the moment Master Passwords has its own pref pane, there is plenty of room in the Passwords pref pane to accommodate those prefs so it makes sense to merge it into a single pref pane.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: help changes, 2 strings removed and 8 strings moved

Attachment #9238489 - Flags: review?(frgrahl)
Attachment #9238489 - Flags: approval-comm-release?
Attachment #9238489 - Flags: approval-comm-esr60?

As suggested rather than moving entities just leave in existing file.
Whilst here also remove 2 unused preference tags that went in Bug 1393151
https://searchfox.org/comm-central/source/suite/components/migration/src/nsThunderbirdProfileMigrator.cpp#416 should probably also go but not sure that is in the scope of this bug.

Attachment #9238489 - Attachment is obsolete: true
Attachment #9238489 - Flags: review?(frgrahl)
Attachment #9238489 - Flags: approval-comm-release?
Attachment #9238489 - Flags: approval-comm-esr60?
Attachment #9238515 - Flags: review?(frgrahl)
Attachment #9238515 - Flags: approval-comm-release?
Attachment #9238515 - Flags: approval-comm-esr60?

Comment on attachment 9238515 [details] [diff] [review]
1728099-prefs-passwords-v1_1-25310.patch

LGTM

Attachment #9238515 - Flags: review?(frgrahl)
Attachment #9238515 - Flags: review+
Attachment #9238515 - Flags: approval-comm-release?
Attachment #9238515 - Flags: approval-comm-release+
Attachment #9238515 - Flags: approval-comm-esr60?
Attachment #9238515 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b36f19814ed1
Merge Master Passwords and Passwords pref panes into a single pref pane. r=frg

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Whiteboard: SM2.53.10
Target Milestone: --- → seamonkey 2.90
You need to log in before you can comment on or make changes to this bug.