1728102 - Interactions.jsm throws on removing a non-existing idle observer

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P2)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Interactions.jsm adds an idle observer only if the pref is set, but unit() tried to remove it regardless. removeIdleObserver unfortunately throws in that case, and thus interrupts browserglue uninit process
https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/browser/components/BrowserGlue.jsm#1967-1974

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1728102 - Interactions.jsm uninit is throwing on removing a non-existing idle observer. r=Standard8

Trying to make _onQuitApplicationGranted more robust, copying the method used for idle tasks.
If successful, we could re-apply the same method to other parts of browserglue doing init/uninit.
To fail tests, this is crashing fatally, it would be nice if we could fail single tests, but
quit-application-granted is too late for test harness failure detection.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67b3dda3d4a7
Interactions.jsm uninit is throwing on removing a non-existing idle observer. r=Standard8

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/67b3dda3d4a7