Closed Bug 1728104 Opened 2 months ago Closed 29 days ago

Consider moving NumberPart definitions to separate header

Categories

(Core :: Internationalization, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: dminor, Assigned: allstars.chh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [i18n-unification])

Attachments

(4 files)

At the moment, we're defining NumberPart in NumberFormatField.h, but NumberPart is part of a public API, and NumberFormatField is not. It might make sense to split these up.

Suggested by Anba in the review of https://phabricator.services.mozilla.com/D121411.

Whiteboard: [i18n-unification]

Yoshi, this is pretty trivial, but maybe you can fix it. It breaks doing local SpiderMonkey non-unified builds. This uses the NumberPart without a definition.

If you set this line to = 1 locally and do a spidermonkey build you will trigger the problem. Also, the ListFormat.cpp files you add need a ScopeICUObject.h include.

Flags: needinfo?(allstars.chh)
Assignee: nobody → allstars.chh
Flags: needinfo?(allstars.chh)
Attachment #9241334 - Attachment description: Bug 1728104. Part 2: Add NumberPart.h. → Bug 1728104 - Part 2: Add NumberPart.h.
Pushed by allstars.chh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2a14ebd378ca
Part 1: Fix non-unified build error on ListFormat.cpp. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e003632d9854
Part 2: Add NumberPart.h. r=platform-i18n-reviewers,anba,dminor
https://hg.mozilla.org/integration/autoland/rev/2bf981a5af72
Part 3: Remove NumberFormatFields.h from exported headers. r=platform-i18n-reviewers,anba,dminor
https://hg.mozilla.org/integration/autoland/rev/e5f2a2c79161
Part 4: Merge NumberFormatFieldsUtil.[cpp|h] into NumberFormatFields.[cpp|h]. r=platform-i18n-reviewers,anba,dminor
You need to log in before you can comment on or make changes to this bug.