1728104 - Consider moving NumberPart definitions to separate header

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Dan Minor [:dminor]]

At the moment, we're defining NumberPart in NumberFormatField.h, but NumberPart is part of a public API, and NumberFormatField is not. It might make sense to split these up.

Suggested by Anba in the review of https://phabricator.services.mozilla.com/D121411.

Comment 1

[Ted Campbell [:tcampbell]]

Yoshi, this is pretty trivial, but maybe you can fix it. It breaks doing local SpiderMonkey non-unified builds. This uses the NumberPart without a definition.

If you set this line to = 1 locally and do a spidermonkey build you will trigger the problem. Also, the ListFormat.cpp files you add need a ScopeICUObject.h include.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1728104 - Part 1: Fix non-unified build error on ListFormat.cpp.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1728104 - Part 2: Add NumberPart.h.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1728104 - Part 3: Remove NumberFormatFields.h from exported headers.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1728104 - Part 4: Merge NumberFormatFieldsUtil.[cpp|h] into NumberFormatFields.[cpp|h].

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a14ebd378ca
Part 1: Fix non-unified build error on ListFormat.cpp. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e003632d9854
Part 2: Add NumberPart.h. r=platform-i18n-reviewers,anba,dminor
https://hg.mozilla.org/integration/autoland/rev/2bf981a5af72
Part 3: Remove NumberFormatFields.h from exported headers. r=platform-i18n-reviewers,anba,dminor
https://hg.mozilla.org/integration/autoland/rev/e5f2a2c79161
Part 4: Merge NumberFormatFieldsUtil.[cpp|h] into NumberFormatFields.[cpp|h]. r=platform-i18n-reviewers,anba,dminor

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/2a14ebd378ca
https://hg.mozilla.org/mozilla-central/rev/e003632d9854
https://hg.mozilla.org/mozilla-central/rev/2bf981a5af72
https://hg.mozilla.org/mozilla-central/rev/e5f2a2c79161