1728141 - Accessibility regression: SubDialog.jsm dialog boxes no longer correctly named

Status: NEW

(Toolkit :: Content Prompts, defect)

Description

[Valentin Villenave]

Attachment: Capture du 2021-08-30 18-02-41.png

When removing an account in TB 93, an unnamed vbox (dialogBox)
appears, containing the title “Remove Account and Data” as a label
(not as the actual accessible name of the element). As a result, the
“Close” button (which takes the focus by default if you actually go
ahead and remove the account) has no named parent that would be
semantically relevant.

There is an appropriately-named dialogBox, but it’s actually nested
inside the aforementioned one and thus is not mentioned when the
Close button is focused.

If, from the Close button, you hit Tab once, then the focus gets to that
internal XUL window, (and its removeAccountDialog box); that dialog
offers no interaction on its own and there’s no visual indication where
the focus is at that point. Hitting Tab once more brings you to the “OK”
button, which actually resides in its purported dialog box.

This was introduced recently as part of the dialog box redesign.

Comment 1

[Thomas D. (:thomas8)]

Hi Valentin, this bug is not actionable. I'll have to ask you to write up a new structured description of this bug which follows the protocol:

• Steps to reproduce (list of numbered steps, every keypress)
• Actual result (preferably bulleted list to keep it short; refer to steps if required)
• Expected result (dito)

The dialog in question has the ID removeAccountDialog: https://searchfox.org/comm-central/rev/8c76e5f3c9f3348c55f4d1dbb7cee84c33daad32/mailnews/base/prefs/content/removeAccount.xhtml#20

Maybe moving the ID from that <dialog> element to the containing <window> element might help? Along bug 1717235.

Comment 2

[Valentin Villenave]

Hi Thomas; sure, here are some step to reproduce:

• Launch Orca, Accerciser, dogtail or any other at-spi aware app.
• Open Thunderbird. (I’m assuming there’s an email account already set up.)
• Go to Account Settings (Alt-E, Up, Up, Return).
• Your current account should already be selected; hit Tab once to reach the “Account Actions” button.
• Open “Remove Account“ (Alt-Down, Up, Return).
• A pop-up frame opens, seemingly titled “Remove Account an Data”. By default, the “Remove message data” check box has the focus.

---

• Explore the at-spi tree (e.g. if using Orca, hit Alt-Tab twice to move the focus elsewhere and back again). You can see (or hear) that this check box is indeed in the “Remove Account and Data” dialog box; so far so good.
• Now hit Shift-Tab (twice) until you reach the “Close” button.
• Explore the at-spi tree again.
• At that point you’ll realize that the “Close” button actually isn’t in the dialog box named “Remove Account and Data”. For example, if using Orca, all you’ll hear is: “Account Settings - Close button”.

---

• Tab into the “Remove” button and hit Space to proceed.
• Now the pop-up frame just sports a confirmation message, but the Close button has the focus by default.
• If you explore the at-spi tree again, you’ll notice that the Close button still isn’t announced as part of the “Remove Account and Data” dialog box. If all you have is the screen reader output, you have no way of knowing what exactly that button is a part of.

Comment 3

[Wayne Mery (:wsmwk)]

Do we know if this issue also exists in version 91?

Comment 4

[Valentin Villenave]

As of 91.0a1 build 20210614103036, it was already there. May I help narrow it further down?

Comment 5

[Geoff Lankow (:darktrojan)]

I expect you get the same issue with dialogs in the Preferences/Settings tab of both Thunderbird and Firefox. There's not a lot we can do about it, apart from move away from this type of dialog, which we're already doing.

Sending this over to the Toolkit component since that's where the code that creates these dialogs comes from.

Comment 6

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.