1728245 - Add profiler markers on WebExtensions Schemas.load calls

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In https://github.com/mozilla-mobile/fenix/issues/20934#issuecomment-903740408, it was determined that two web extensions' manifests were taking a long time to parse on start up and that was the cause for the regression. It seems like the root cause would have been more apparent if we had profiler markers that indicated that a WebExtension's manifest is being parsed with detail text that says which extension is being parsed; this could either be a single marker when parsing begins or a marker with a duration (parsing start/end). For example:

Extension.parseManifest
Details: [e-mail]

Additionally, it could be useful to add markers for other major events in extensions during start up – unfortunately, I'm unfamiliar with the code so I can't be more specific.

Note: we have a TelemetryStopwatch - WEBEXT_EXTENSION_STARTUP_MS_BY_ADDONID:[e-mail] profiler maker but I'm not sure it's correct and what specifically it's describing.

Comment 1

[Tomislav Jovanovic :zombie]

Changing severity to S? because of <this is an enhancement>

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1728245: Add profile marker on WebExtensions Schemas.load. r?florian!

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

The marker on the telemetry stopwatch collected when we are starting an extension should also be useful for being able to identify which extension is starting through the related profile marker.

But a marked added from Schemas.load would have helped a lot to more easily identify the underlying issue in Bug 1728461.

The following are two profiles collected with the attached patch (along with Rob's patch from Bug 1728461):

• profile collected while the JSONSchema data was loaded from file on the first startup: https://share.firefox.dev/3txfPlm
• profile collected when the JSONSchema data was loaded from the startupCache on the second startup: https://share.firefox.dev/2X4ToYn

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52ce21dcb6a2
Add profile marker on WebExtensions Schemas.load. r=florian

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/52ce21dcb6a2

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Update the bug summary to reflect the actual change landed.