1728251 - Remove nsDisplayItem::mClip

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Description

[Matt Woodrow (:mattwoodrow)]

Looks like this is just a cached value from the clip chain, and we don't use it for the normal WR painting path.

We should be able to drop the cached value, and just compute it on demand instead.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1728251 - Remove FuseClipChainUpTo since its unused. r?miko

Depends on D124006

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1728251 - Remove mClip and compute it when we need it. r?miko

Depends on D124007

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/405ff2ed2110
Remove FuseClipChainUpTo since its unused. r=miko
https://hg.mozilla.org/integration/autoland/rev/7217ecf149c4
Remove mClip and compute it when we need it. r=miko

Comment 4

[Marian-Vasile Laza]

Backed out 7 changesets (Bug 1728050, Bug 1728251, Bug 1728232, Bug 1542929, Bug 1714138, Bug 1728258) for causing reftest failures.
Backout link
Push with failures R8
Also on multiple platforms - Rs6 R5
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7a8bf19d849
Remove FuseClipChainUpTo since its unused. r=miko
https://hg.mozilla.org/integration/autoland/rev/96be978630ff
Remove mClip and compute it when we need it. r=miko

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d7a8bf19d849
https://hg.mozilla.org/mozilla-central/rev/96be978630ff

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing Bug 1424348 a=backout
Backout link : https://hg.mozilla.org/mozilla-central/rev/e8e345cec68d8e71ba6f6f3c5ff2fe33605c670f

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/828ea702c5d4
Remove FuseClipChainUpTo since its unused. r=miko
https://hg.mozilla.org/integration/autoland/rev/49b986018657
Remove mClip and compute it when we need it. r=miko

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/828ea702c5d4
https://hg.mozilla.org/mozilla-central/rev/49b986018657