1728284 - Post lint results to Lando

Status: RESOLVED FIXED

(Firefox Build System :: Source Code Analysis, enhancement)

Description

[Marco Castelluccio [:marco]]

In bug 1699137, we're introducing a new API in Lando to upload warnings the user must ack before landing.

We should use this API in the code review bot to upload lint results to Lando in addition to Phabricator.

Comment 1

[Andrew Halberstadt [:ahal]]

We should also post non-lint failures as well as a warning when tasks are unfinished (maybe the latter should be a separate check box?)

Comment 2

[Marco Castelluccio [:marco]]

(In reply to Andrew Halberstadt [:ahal] from comment #1)

We should also post non-lint failures as well as a warning when tasks are unfinished (maybe the latter should be a separate check box?)

Yes, any failure will be posted (I called them "lint results" because that's the Phabricator nomenclature, but actually they can be anything).

Regarding unfinished tasks, with the API defined in bug 1699137 we'll send a first "build in progress" warning, then when the actual results come in we remove it and upload the actual failures (or nothing if there was no failure).

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/code-review/pull/975

Comment 4

[Andi [:andi]]

This has been done but we are waiting for the latest version of lando to be deployed.