Closed Bug 1728284 Opened 5 months ago Closed 4 months ago

Post lint results to Lando

Categories

(Firefox Build System :: Source Code Analysis, enhancement)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: marco, Assigned: andi)

References

Details

Attachments

(1 file)

In bug 1699137, we're introducing a new API in Lando to upload warnings the user must ack before landing.

We should use this API in the code review bot to upload lint results to Lando in addition to Phabricator.

We should also post non-lint failures as well as a warning when tasks are unfinished (maybe the latter should be a separate check box?)

(In reply to Andrew Halberstadt [:ahal] from comment #1)

We should also post non-lint failures as well as a warning when tasks are unfinished (maybe the latter should be a separate check box?)

Yes, any failure will be posted (I called them "lint results" because that's the Phabricator nomenclature, but actually they can be anything).

Regarding unfinished tasks, with the API defined in bug 1699137 we'll send a first "build in progress" warning, then when the actual results come in we remove it and upload the actual failures (or nothing if there was no failure).

See Also: → 1728341
Assignee: nobody → bpostelnicu
Status: NEW → ASSIGNED

This has been done but we are waiting for the latest version of lando to be deployed.

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.