1728413 - mistik.xtr.jp doesn't load

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Ksenia Berezina [:ksenia]]

This was initially reported in https://github.com/webcompat/web-bugs/issues/85166

To reproduce visit https://mistik.xtr.jp/ml_ssr/ and observe the site

Expected:
Site loads

Actual:
Site never finishes loading

From mozregression:

13:01.59 INFO: Narrowed integration regression window from [e2bac24e, a45808c1] (3 builds) to [e2bac24e, 09c598c8] (2 builds) (~1 steps left)
13:01.59 INFO: No more integration revisions, bisection finished.
13:01.59 INFO: Last good revision: e2bac24ec485f16267aa61e500ef566ce1d75525
13:01.59 INFO: First bad revision: 09c598c8fd29606df563d24b8f9c3a67ffbd4b7a
13:01.59 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e2bac24ec485f16267aa61e500ef566ce1d75525&tochange=09c598c8fd29606df563d24b8f9c3a67ffbd4b7a

Comment 1

[Ksenia Berezina [:ksenia]]

Hi Peter, could you please take a look?

Comment 2

[Chris Peterson [:cpeterson]]

The webcompat issue was reported for Firefox 91 three days ago, so the user was presumably not using Fission.

Comment 3

[Peter Van der Beken [:peterv]]

I can't reproduce this anymore, I wonder if the site has changed.

Comment 4

[Jens Stutte [:jstutte]]

Hi Ksenia, can you confirm and in case close this? Thank you!

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

peterv just said on matrix he did manage to reproduce this again :)

Comment 6

[Peter Van der Beken [:peterv]]

Actually, I can reproduce it. But it might be fission-only?

Comment 7

[Ksenia Berezina [:ksenia]]

I can reproduce this still. Also tried with fission disabled, the site also doesn't load

Comment 8

[Peter Van der Beken [:peterv]]

Attachment: Bug 1728413 - mistik.xtr.jp doesn't load. r?smaug!

Getting all the requests from the loadgroup every time a request
is added or removed was causing performance issues. It turns out
that it wasn't really needed for determining if a page should be
blocked from the BFCache, since we just need to know if there
are any requests in the loadgroup, and if so, if all it contains
is just one request with an id. We can keep a count of relevant
requests in the loadgroup. When the count changes to 1, on adding
we can inspect the request that's being added, and on removal we
can inspect the requests in the loadgroup (which should be now be
cheap enough, since there's only 1 relevant request in the list).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bf41da9f467
mistik.xtr.jp doesn't load. r=smaug

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0bf41da9f467

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Should we consider this for ESR91 uplift? Looks like it grafts cleanly.

Comment 13

[Peter Van der Beken [:peterv]]

Comment on attachment 9240615 [details]
Bug 1728413 - mistik.xtr.jp doesn't load. r?smaug!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This bug result in some sites not loading at all.
• User impact if declined: Some sites don't load anymore.
• Fix Landed on Version: 94
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The algorithm for determining if something should go into the BFCache with Fission enabled was changed to be simpler, to resolve a performance issue. Apart from the improved performance, the change would only affect BFCaching if Fission is enabled.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9240615 [details]
Bug 1728413 - mistik.xtr.jp doesn't load. r?smaug!

This has gotten pretty significant bake time on release and fixes some known site bustages in the wild. Approved for 91.6esr.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/d6b06f985900

Comment 16

[Anca Soncutean, Desktop QA]

Reproduced with 91.5.1esr on Windows 10.
Verified fixed with 91.6.0esr on Windows 10, macOS 10.13 and Ubuntu 20.04.