Closed Bug 1728423 Opened 3 months ago Closed 3 months ago

Migrate display list building time metric to glean

Categories

(Core :: Graphics, task)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

The current distribution of buckets makes it so most people just end up in zero. This make it mostly unusable for tracking the impact of our changes to display list building time.

Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED
Attached file collection.md (obsolete) —
Attachment #9238791 - Flags: data-review?(chutten)

Comment on attachment 9238791 [details]
collection.md

Q7 needs an individual to be responsible for the collection. :jrmuizel, is this you?

Flags: needinfo?(jmuizelaar)
Attachment #9238791 - Flags: data-review?(chutten)
Attached file collection.md
Attachment #9238791 - Attachment is obsolete: true
Flags: needinfo?(jmuizelaar)
Attachment #9238990 - Flags: data-review?(chutten)

Comment on attachment 9238990 [details]
collection.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jeff Muizelaar is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9238990 - Flags: data-review?(chutten) → data-review+
Blocks: 1728642
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5281f57107c7
Migrate display list building time metric to glean. r=chutten,miko
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Regressions: 1729723

Backed out as per request for hangs in nsLayoutUtils::PaintFrame (bug 1729723).

Status: RESOLVED → REOPENED
Flags: needinfo?(jmuizelaar)
Resolution: FIXED → ---
Target Milestone: 93 Branch → ---
Blocks: 1730249

(In reply to Sandor Molnar from comment #10)

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/7bd5371059b624910962658953e2cb2046de2db4

== Change summary for alert #31292 (as of Mon, 13 Sep 2021 11:17:56 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
5% tart macosx1015-64-shippable-qr e10s stylo webrender 2.25 -> 2.13
4% tart macosx1015-64-shippable-qr e10s stylo webrender-sw 2.20 -> 2.12
4% tart macosx1015-64-shippable-qr e10s stylo webrender-sw 2.21 -> 2.12

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=31292

Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/baafe21d9780
Migrate display list building time metric to glean. r=chutten,miko
Status: REOPENED → RESOLVED
Closed: 3 months ago3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.