1728423 - Migrate display list building time metric to glean

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Jeff Muizelaar [:jrmuizel]]

The current distribution of buckets makes it so most people just end up in zero. This make it mostly unusable for tracking the impact of our changes to display list building time.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1728423 - Migrate display list building time metric to glean.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: collection.md

Comment 3

[Chris H-C :chutten]

Comment on attachment 9238791 [details]
collection.md

Q7 needs an individual to be responsible for the collection. :jrmuizel, is this you?

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: collection.md

Comment 5

[Chris H-C :chutten]

Comment on attachment 9238990 [details]
collection.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jeff Muizelaar is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5281f57107c7
Migrate display list building time metric to glean. r=chutten,miko

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5281f57107c7

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out as per request for hangs in nsLayoutUtils::PaintFrame (bug 1729723).

• backout: https://hg.mozilla.org/integration/autoland/rev/7bd5371059b624910962658953e2cb2046de2db4

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out from beta (Gecko 93): https://hg.mozilla.org/releases/mozilla-beta/rev/f233798677744deca20666da265d6c3f44e1a356

Comment 10

[Sandor Molnar]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/7bd5371059b624910962658953e2cb2046de2db4

Comment 11

[Andra Esanu]

(In reply to Sandor Molnar from comment #10)

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/7bd5371059b624910962658953e2cb2046de2db4

== Change summary for alert #31292 (as of Mon, 13 Sep 2021 11:17:56 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	tart	macosx1015-64-shippable-qr	e10s stylo webrender	2.25 -> 2.13
4%	tart	macosx1015-64-shippable-qr	e10s stylo webrender-sw	2.20 -> 2.12
4%	tart	macosx1015-64-shippable-qr	e10s stylo webrender-sw	2.21 -> 2.12

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=31292

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baafe21d9780
Migrate display list building time metric to glean. r=chutten,miko

Comment 13

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/baafe21d9780