172844 - Installer for Mozilla Palm HotSync Conduit

Status: VERIFIED FIXED

(MailNews Core Graveyard :: Palm Sync, defect)

Description

[Rajiv Dayal]

Enabling Mozilla PalmSync in order to allow synchronization of Palm handheld
Address Book with Mozilla AB requires to install the Mozilla HotSync Conduit so
that it is used by the Palm HotSync Manager when a Palm sync operation is
performed. In order to do so a Palm Conduit Installer needs to be developed
which will register Mozilla's HotSync Conduit with the HotSync Conduit Manager
and the HotSync Manager. This installer will be installed by Mozilla Installer
and will be made a Program sub-menu to allow the user to execute this Palm
Conduit installer when he wants to start synchronizing his Palm with Mozilla
Address Book.

Comment 1

[Rajiv Dayal]

The Palm Conduit Installer will load a copy of Conduit Manager Dll and HotSync
Manager API Dll for which Palm provides permission to redistribute. The
installer will then call the CondMgr.Dll and HSAPI.Dll functions, the function
addresses of which is retrieved using function names from the loaded Dlls, in
order to register the Mozilla AB HotSync Conduit and restart the HotSync Manager
to enable sync with Mozilla Address Books.

Comment 2

[Rajiv Dayal]

Attachment: patch for the Palm Conduit Installer

This code for this installer would go in the directory:
'mozilla/xpinstall/wizard/windows/palmsync'.

This installer is a standalone executable which will install the Conduit and
exit. For this Mozilla is not required to be running.

Sean, can u please review this patch.

Comment 3

[Rajiv Dayal]

Attachment: updated patch enabling Uninstall of the Conduit

-Code has been added to call the Uninstall function using commandline options.
-Changed the Uninstall function to not just uninstall Mozilla HotSync Conduit
but reset the default Palm Desktop configuration to allow sync with Palm
Desktop. -Changed code to use resource strings for title. 
-Added Mozilla license plates.

Sean can u review this patch, thanks.

Comment 4

[Sean Su]

Comment on attachment 101882 [details] [diff] [review]
updated patch enabling Uninstall of the Conduit

1) looks like the license is an old version in makefile.in.

2) Should try to resource this string too:

+    if(res > IDS_ERR_MAX || res < IDS_ERR_GENERAL)
+  res = IDS_ERR_GENERAL;
+    LoadString(hInstance, res, msgStr, MAX_LOADSTRING);
+    MessageBox(NULL, msgStr, "Mozilla PalmSync Installer", MB_OK);

3) you can merge:
+   if( *cPtr == DIRECTORY_SEPARATOR )
+     *cPtr = '\0';

into:
+   while( cPtr >= pPDInstallDirectory )
+   {
+     if( *cPtr == DIRECTORY_SEPARATOR )
+	break;
+     cPtr--;
+   }

4) don't forget to add the '/s' (silent) option to at least the uninstallation
part.  I rather see this as part of the install as well as the uninstall.

Comment 5

[Rajiv Dayal]

Attachment: updated patch with silent option

takes care of most comments, minor makefile changes to do conditional build,
has the silent option for both install and uninstall.

Comment 6

[Sean Su]

Comment on attachment 102073 [details] [diff] [review]
updated patch with silent option

the license part in the Makefile.in still doesn't look like it's the right one.
 I'm comparing it against the ones listed in http://www.mozilla.org/MPL

r=ssu once that's fixed

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 102073 [details] [diff] [review]
updated patch with silent option

sr=dveditz

Comment 8

[Rajiv Dayal]

thanks Dan.

Comment 9

[Rajiv Dayal]

This has landed, marking as fixed.

Comment 10

[Larry Lade]

Running the conduit uninstaller on my Win98 system had the very negative effect
of deleting my Palm Desktop user profile! (Data was intact, apparently just
messed up the registry.) Had to uninstall/reinstall Palm Desktop to repair.

Running Palm Desktop 4.1, Mozilla release 1.2 (20021126)

Comment 11

[Ben Liblit]

Regarding Larry Lade's comment #10:

I got hit by the same problem, which I have reported as bug 182423.  See that
report for more info, including an easier way to undo the damage by manually
editing a registry key.

Comment 12

[Ninoschka Baca]

Trunk build 2003-02-20: WinXP
Verified Fixed. This has been fixed for awhile.