1728565 - Move TypedArray and ArrayBuffer allocation out of the generic allocation code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

The generic allocation path is a lot simpler than before, but it still has some branching for objects that store data inline (typed arrays and array buffers) because this affects the number of fixed slots.

If we move allocation of these objects out of there we can turn that ClassCanHaveFixedData check into an assertion.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1728565 part 1 - Move ArrayBuffer allocation out of the generic allocation code. r?sfink!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1728565 part 2 - Use ArrayBuffer arena for all ArrayBuffer objects. r?sfink!

Depends on D124324

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1728565 part 3 - Move TypedArray allocation out of the generic allocation code. r?sfink!

Depends on D124325

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1728565 part 4 - Remove support for objects with fixed data from the generic allocation path. r?sfink!

Depends on D124326

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ea3c57fa362
part 1 - Move ArrayBuffer allocation out of the generic allocation code. r=sfink
https://hg.mozilla.org/integration/autoland/rev/0d17023ae58e
part 2 - Use ArrayBuffer arena for all ArrayBuffer objects. r=sfink
https://hg.mozilla.org/integration/autoland/rev/68c8333149ed
part 3 - Move TypedArray allocation out of the generic allocation code. r=sfink
https://hg.mozilla.org/integration/autoland/rev/706403fcb982
part 4 - Remove support for objects with fixed data from the generic allocation path. r=sfink

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/7ea3c57fa362
https://hg.mozilla.org/mozilla-central/rev/0d17023ae58e
https://hg.mozilla.org/mozilla-central/rev/68c8333149ed
https://hg.mozilla.org/mozilla-central/rev/706403fcb982