1728618 - Show shader build times in the profiler HUD

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

Shader compilation can take a while, so let's show it in the intergated profiler HUD.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1728618 - Show shader build times in the wr profiler. r=#gfx-reviewers

Comment 2

[Nicolas Silva [:nical]]

Attachment: WIP: Bug 1728618 - WIP - categorize slow frames.

Depends on D124218

Comment 3

[Phabricator Automation]

Comment on attachment 9238968 [details]
WIP: Bug 1728618 - WIP - categorize slow frames.

Revision D124219 was moved to bug 1728620. Setting attachment 9238968 [details] to obsolete.

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1728618 - Add a profile marker for shader compilation. r=#gfx-reviewers

Depends on D124218

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9189be4cd58
Show shader build times in the wr profiler. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/eba492819020
Add a profile marker for shader compilation. r=gfx-reviewers,jrmuizel

Comment 6

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1728618) for causing build bustages on lib.rs.
Backout link
Push with failures
Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e8982292856
Show shader build times in the wr profiler. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/f85757f1ba06
Add a profile marker for shader compilation. r=gfx-reviewers,jrmuizel

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abc2fd25b16c
Backed out 2 changesets for causing valgrind bustages.

Comment 9

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1728618) for causing valgrind bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/abc2fd25b16cc2396840805e9a756b8e5c5f2f80
Push with failures, failure log.

Comment 10

[Nicolas Silva [:nical]]

Attachment: Bug 1728618 - Suppress false positive valgrind uninitialized value error. r=#gfx-reviewers

Valgrind detects a condition depending on uninitialized value in update_texture_cache. I first ran into this in bug 1716579, and as patch had a large impact on allocation/deallocation workloads with the texture cache, I couldn't decide with confidence that the patch wasn't faulty. In bug 1728618 which causes this error again, however, the patch is much simpler, doesn't interact with unsafe code and does not affect texture cache workloads so it gives me much better confidence that this valgrind error is either a false positive or a miscompilation.

Depends on D124247

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a65045f3472f
Show shader build times in the wr profiler. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/3a55d35e08a0
Add a profile marker for shader compilation. r=gfx-reviewers,jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6582d7723586
Suppress false positive valgrind uninitialized value error. r=gfx-reviewers,aosmond

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a65045f3472f
https://hg.mozilla.org/mozilla-central/rev/3a55d35e08a0
https://hg.mozilla.org/mozilla-central/rev/6582d7723586