1728669 - Simplify extensionFromBundle(senderBundle) logic in WebExtensionController.java

Status: RESOLVED FIXED

(GeckoView :: Extensions, task, P3)

Description

[Rob Wu [:robwu]]

WebExtensionController.java reads the extensionId from the bundle, except for extension messages. In extension messages, the internal sender.extensionId was unintentionally exposed, but when that was fixed in D123351 (part of bug 1708243), sender.extensionId got added again.

The logic could be simplified by unconditionally reading extensionId off the bundle, as explained at https://phabricator.services.mozilla.com/D123351#4033719

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1728669 - Simplify GeckoView:WebExtension:Connect/Message handlers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35295637d5fd
Simplify GeckoView:WebExtension:Connect/Message handlers r=agi

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_ext_tabs_executeScript_good.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/214cd072efe2e84a3573933ba51de6f9ede08d79
Log link: https://treeherder.mozilla.org/logviewer?job_id=350268167&repo=autoland&lineNumber=2599

Comment 4

[Rob Wu [:robwu]]

Ah.... https://searchfox.org/mozilla-central/rev/49b6e60550243b4b4d71d6ab35a3ff2b9a9f7c69/mobile/android/modules/test/AppUiTestDelegate.jsm#25,29,35

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/452f3a79c1b2
Simplify GeckoView:WebExtension:Connect/Message handlers r=agi

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/452f3a79c1b2

Comment 7

[Chris Peterson [:cpeterson]]

Moving some WebExtension bugs to the GeckoView::Extensions component.