Closed Bug 1728669 Opened 3 months ago Closed 3 months ago

Simplify extensionFromBundle(senderBundle) logic in WebExtensionController.java

Categories

(GeckoView :: General, task, P3)

Unspecified
All

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

Details

Attachments

(1 file)

WebExtensionController.java reads the extensionId from the bundle, except for extension messages. In extension messages, the internal sender.extensionId was unintentionally exposed, but when that was fixed in D123351 (part of bug 1708243), sender.extensionId got added again.

The logic could be simplified by unconditionally reading extensionId off the bundle, as explained at https://phabricator.services.mozilla.com/D123351#4033719

Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/35295637d5fd
Simplify GeckoView:WebExtension:Connect/Message handlers r=agi
Flags: needinfo?(rob)
Priority: -- → P3
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/452f3a79c1b2
Simplify GeckoView:WebExtension:Connect/Message handlers r=agi
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.