1728851 - Consider adding attributes to the rule hash.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1728851 - Add attributes to the rule hash. r=#style,#layout-reviewers

See the discussion here: https://twitter.com/Rich_Harris/status/1433153204678799365

This should make attribute selectors roughly as fast as class selectors.

I think it's worth trying and see if perf bots complain on
micro-benchmarks and stylebench and such.

I made attributes more specific than local names, but less specific than
classes, which I think makes sense. When doing something like
foo[data-bar], filtering by data-bar seems likely to yield less elements
than filtering by foo.

While at it, remove the bloom filter pref since we shipped it in
bug 1704551 for 87 and we haven't heard complaints.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/876e53ec90c4
Add attributes to the rule hash. r=boris

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out as requested by Emilio. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/caf232cb6cb15309968d8d7b0ebc3a7139235142
Link to push : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=876e53ec90c4367c97c384877985d3ac4f695cf8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf3860b3652e
Add attributes to the rule hash. r=boris

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/cf3860b3652e