1728953 - Remove unused flag from nsXULPrototypeCache

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/55e8eba74b60b92d04b781f7928f54ef76b13fa9/js/xpconnect/src/nsXPConnect.cpp#927-931

NS_IMETHODIMP
nsXPConnect::WriteScript(nsIObjectOutputStream* stream, JSContext* cx,
                         JSScript* scriptArg) {
...
  uint8_t flags = 0;  // We don't have flags anymore.
  nsresult rv = stream->Write8(flags);
  if (NS_FAILED(rv)) {
    return rv;
  }
...
NS_IMETHODIMP
nsXPConnect::ReadScript(nsIObjectInputStream* stream, JSContext* cx,
                        const JS::ReadOnlyCompileOptions& options,
                        JSScript** scriptp) {
  uint8_t flags;
  nsresult rv = stream->Read8(&flags);
  if (NS_FAILED(rv)) {
    return rv;
  }

we can remove the flags byte.

NOTE: the code is going to be moved to dom/xul/nsXULElement.cpp in https://phabricator.services.mozilla.com/D121254

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1728953 - Remove unused flag from nsXULPrototypeCache. r?kmag!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51e004a9b248
Remove unused flag from nsXULPrototypeCache. r=kmag

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/51e004a9b248