1728954 - Simplify BaseScript::functionOrGlobal_ field

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

after bug 1662152, ScriptSourceObject is always canonical, and it means the ScriptSourceObject and BaseScript can always be in same realm.

and in that case global script can use sourceObject_->realm() instead of holding the global object in BaseScript::functionOrGlobal_ field

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Changing severity to S4.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1728954 - Use ScriptSourceObject as a source of realm/compartment in BaseScript. r?jandem!

BaseScript::functionOrGlobal_ is renamed to BaseScript::function_ and holds
JSFunction only when the script is function.

BaseScript ctor is moved to JSScript.cpp because GCPtr<JSFunction*> ctor
requires JSFunction definition.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/057e1437a1f7
Use ScriptSourceObject as a source of realm/compartment in BaseScript. r=jandem

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/057e1437a1f7