1729001 - FirefoxHome->Pocket policy doesn't disable/change entries in preferences

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P2)

Description

[Mike Kaply [:mkaply]]

If you use the FirefoxHome->Pocket policy, it does make Pocket disappear, but it has no effect on the preferences entries.

Comment 1

[Mike Kaply [:mkaply]]

Github issue where this was found: https://github.com/mozilla/policy-templates/issues/796

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1729001 - Lock pocket new tab in preferences. r?thecount!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c29a6a124dc4
Lock pocket new tab in preferences. r=thecount

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c29a6a124dc4

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Mike Kaply [:mkaply]]

I'm not going to worry about this on beta, it can ride the trains. I'll request uplift to ESR after we ship.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Is this ready for an ESR uplift request?

Comment 8

[Mike Kaply [:mkaply]]

yes, sorry. I have a list and I'm a little behind.

Comment 9

[Mike Kaply [:mkaply]]

I need to verify the test works on ESR then I'll request uplift Monday.

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 9240650 [details]
Bug 1729001 - Lock pocket new tab in preferences. r?thecount!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: policy related, parity with Firefox 94
• User impact if declined: When pocket is disabled via policy in new tab, it's still enabled in the product
• Fix Landed on Version: 94
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, automated test.
• String or UUID changes made by this patch:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9240650 [details]
Bug 1729001 - Lock pocket new tab in preferences. r?thecount!

Approved for 91.3esr.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/7005debd8df7

Comment 13

[Petruta Horea [:phorea]]

Reproduced using Firefox 91.2de build and { "policies": { "FirefoxHome": { "Pocket": false } }} policy.

Verified as fixed using Firefox 91.3 de and en-US builds and Firefox 94RC.