1729044 - [ipdl] Remove support for `intr` messages

Status: RESOLVED FIXED

(Core :: IPC, task)

Description

[Nika Layzell [:nika] (ni? for response)]

The intr message type (formerly rpc) has a lot of code dedicated to handling the edge cases associated with it in IPDL and MessageChannel. There are very few remaining uses of the message type in IPC (https://searchfox.org/mozilla-central/search?q=%5Cbintr%5Cb&path=.ipdl&case=false&regexp=true). Once we remove all of those intr messages, it would be nice to clean up & remove the code for the message type completely.

Comment 1

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1729044 - Remove ipdl support for intr r=#ipc-reviewers

This removes intr support and updates some stale docs as well.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a9b63318958
Remove ipdl support for intr r=ipc-reviewers,nika

Comment 3

[Iulian Moraru]

Backed out for causing linux build bustages.

• Push with failures

• Failure log

• Backout link

[task 2024-03-19T02:51:05.598Z] 02:51:05     INFO -  check> gmake[4]: Entering directory '/builds/worker/workspace/obj-build/ipc/ipdl/test/ipdl'
[task 2024-03-19T02:51:05.598Z] 02:51:05     INFO -  check> ...........FF.......................F...F..........F........F..F..................FFFF.........F......FFF....F..............FF.......F.....................FFF..........F.......
[task 2024-03-19T02:51:05.598Z] 02:51:05     INFO -  check> ======================================================================
[task 2024-03-19T02:51:05.598Z] 02:51:05     INFO -  check> FAIL: test (__main__.OkTestCase)
[task 2024-03-19T02:51:05.598Z] 02:51:05     INFO -  check> OkTestCase test of "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok/PMessageTainted.ipdl"
[task 2024-03-19T02:51:05.599Z] 02:51:05     INFO -  check> ----------------------------------------------------------------------
[task 2024-03-19T02:51:05.599Z] 02:51:05    ERROR -  check> Traceback (most recent call last):
[task 2024-03-19T02:51:05.599Z] 02:51:05     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/runtests.py", line 16, in test
[task 2024-03-19T02:51:05.599Z] 02:51:05     INFO -  check>     self.checkPassed()
[task 2024-03-19T02:51:05.599Z] 02:51:05     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/runtests.py", line 50, in checkPassed
[task 2024-03-19T02:51:05.599Z] 02:51:05     INFO -  check>     self.assertTrue(self.compile.ok(), self.mkFailMsg())
[task 2024-03-19T02:51:05.600Z] 02:51:05     INFO -  check> AssertionError: False is not true :
[task 2024-03-19T02:51:05.600Z] 02:51:05     INFO -  check> ### Command: /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/ipc/ipdl/ipdl.py --sync-msg-list=/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/sync-messages.ini --msg-metadata=/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/message-metadata.ini -I /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok -d /tmp/ipdl_unit_testcd6lz955 /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok/PMessageTainted.ipdl
[task 2024-03-19T02:51:05.600Z] 02:51:05     INFO -  check> ### stderr:
[task 2024-03-19T02:51:05.600Z] 02:51:05    ERROR -  check> /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok/PMessageTainted.ipdl:2: error: bad syntax near `intr'
[task 2024-03-19T02:51:05.601Z] 02:51:05     INFO -  check> Specification could not be parsed.
[task 2024-03-19T02:51:05.601Z] 02:51:05     INFO -  check>
[task 2024-03-19T02:51:05.601Z] 02:51:05     INFO -  check>
[task 2024-03-19T02:51:05.601Z] 02:51:05     INFO -  check> ======================================================================
[task 2024-03-19T02:51:05.601Z] 02:51:05     INFO -  check> FAIL: test (__main__.OkTestCase)
[task 2024-03-19T02:51:05.601Z] 02:51:05     INFO -  check> OkTestCase test of "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok/PMessageTaintedWithPassback.ipdl"
[task 2024-03-19T02:51:05.602Z] 02:51:05     INFO -  check> ----------------------------------------------------------------------
[task 2024-03-19T02:51:05.602Z] 02:51:05    ERROR -  check> Traceback (most recent call last):
[task 2024-03-19T02:51:05.602Z] 02:51:05     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/runtests.py", line 16, in test
[task 2024-03-19T02:51:05.602Z] 02:51:05     INFO -  check>     self.checkPassed()
[task 2024-03-19T02:51:05.602Z] 02:51:05     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/runtests.py", line 50, in checkPassed
[task 2024-03-19T02:51:05.602Z] 02:51:05     INFO -  check>     self.assertTrue(self.compile.ok(), self.mkFailMsg())
[task 2024-03-19T02:51:05.602Z] 02:51:05     INFO -  check> AssertionError: False is not true :
[task 2024-03-19T02:51:05.603Z] 02:51:05     INFO -  check> ### Command: /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/ipc/ipdl/ipdl.py --sync-msg-list=/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/sync-messages.ini --msg-metadata=/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/message-metadata.ini -I /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok -d /tmp/ipdl_unit_testzud4chla /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok/PMessageTaintedWithPassback.ipdl
[task 2024-03-19T02:51:05.603Z] 02:51:05     INFO -  check> ### stderr:
[task 2024-03-19T02:51:05.603Z] 02:51:05    ERROR -  check> /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok/PMessageTaintedWithPassback.ipdl:2: error: bad syntax near `intr'
[task 2024-03-19T02:51:05.603Z] 02:51:05     INFO -  check> Specification could not be parsed.
[task 2024-03-19T02:51:05.603Z] 02:51:05     INFO -  check>
[task 2024-03-19T02:51:05.603Z] 02:51:05     INFO -  check>
[task 2024-03-19T02:51:05.604Z] 02:51:05     INFO -  check> ======================================================================
[task 2024-03-19T02:51:05.604Z] 02:51:05     INFO -  check> FAIL: test (__main__.OkTestCase)
[task 2024-03-19T02:51:05.604Z] 02:51:05     INFO -  check> OkTestCase test of "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/ok/Pbytebuf.ipdl"
[task 2024-03-19T02:51:05.604Z] 02:51:05     INFO -  check> ----------------------------------------------------------------------
[task 2024-03-19T02:51:05.604Z] 02:51:05    ERROR -  check> Traceback (most recent call last):
[task 2024-03-19T02:51:05.605Z] 02:51:05     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/runtests.py", line 16, in test
[task 2024-03-19T02:51:05.605Z] 02:51:05     INFO -  check>     self.checkPassed()
[task 2024-03-19T02:51:05.605Z] 02:51:05     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/runtests.py", line 50, in checkPassed
[task 2024-03-19T02:51:05.605Z] 02:51:05     INFO -  check>     self.assertTrue(self.compile.ok(), self.mkFailMsg())
[task 2024-03-19T02:51:05.605Z] 02:51:05     INFO -  check> AssertionError: False is not true :
<...>

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f79aeb1ef7b1
Remove ipdl support for intr r=ipc-reviewers,nika

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f79aeb1ef7b1