1729060 - Replace `taskgraph --diff` with the implementation in standalone taskgraph

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

The --diff implementation in standalone taskgraph now (or will soon) supports diffing against multiple parameters files in parallel. We'll need to sync this implementation over to mozilla-central if we want a task to use it.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1729060 - Sync parameters changes from standalone taskgraph, r?#taskgraph-reviewers!

This syncs changes from:
https://hg.mozilla.org/ci/taskgraph/rev/da7774fc0416bfa7be8c915bf7a4a92c06eeb779

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1729060 - [taskgraph] Sync standalone taskgraph's --diff implementation, r?#taskgraph-reviewers!

This syncs the remaind of bug 1720715 from standalone taskgraph and modifies
the 'mach_commands.py' file to use it.

Of note is the 'setup_logging' override. This is necessary because once we set
up termimal logging in 'mach', it would be difficult for standalone taskgraph
to remove it again in the event we want to redirect logs to file. This way we
can avoid setting it up in the first place and while still keeping Gecko-isms
out of main.py.

Depends on D124831

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1729060 - [taskgraph] Include 'basename' of current directory in log path, r?#taskgraph-reviewers!

This ensures logs from e.g Gecko won't get mixed up with ones from Fenix.

Depends on D124832

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1729060 - [taskgraph] Use --diff implementation from 'main.py', r?#taskgraph-reviewers!

This replaces Gecko's old '--diff' implementation with the one included with
standalone taskgraph.

Note this revision is a straight sync from standalone taskgraph and should not
contain any additional changes.

Depends on D124835

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1729060 - [taskgraph] Add '-J' warning back in when comparing diffs, r?#taskgraph-reviewers!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10a72f098be5
[taskgraph] Sync standalone taskgraph's --diff implementation, r=taskgraph-reviewers,bhearsum
https://hg.mozilla.org/integration/autoland/rev/4662c81ea309
[taskgraph] Include 'basename' of current directory in log path, r=taskgraph-reviewers,jmaher
https://hg.mozilla.org/integration/autoland/rev/253231954d77
[taskgraph] Use --diff implementation from 'main.py', r=taskgraph-reviewers,bhearsum
https://hg.mozilla.org/integration/autoland/rev/0afe2b1f31b4
[taskgraph] Add '-J' warning back in when comparing diffs, r=taskgraph-reviewers,bhearsum

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/10a72f098be5
https://hg.mozilla.org/mozilla-central/rev/4662c81ea309
https://hg.mozilla.org/mozilla-central/rev/253231954d77
https://hg.mozilla.org/mozilla-central/rev/0afe2b1f31b4