1729178 - Add web-server only test coverage for search queries to searchfox-tool/insta-check mechanism

Status: RESOLVED FIXED

(Webtools :: Searchfox, enhancement)

Description

[Andrew Sutherland [:asuth] (he/him)]

The primary regressions in bug 1641372 were due to the lack of test coverage for the search query results. While the local-index abstract server can't perform query checks as this basically entails moving much of router.py to rust, the tests can be run in the web server mode and skipped in local index mode.

The general plan is:

• Add a "query" command to searchfox-tool.
• Have test_check_insta.rs ignore test cases where the pipeline returns ServerError::Unsupported, at least in local indexer mode. (A concern would be a regression failure mode where everything suddenly starts returning Unsupported, but since all of this code is written in rust, not JS, that's not a likely failure mode to accidentally introduce.)
• Add query coverage of the single-override case added in bug 1728376.
• Add an additional dual-override case for bug 1729164 and maybe a triple-override case too since we might want to merge in the dual case as well.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: mozsearch: Build serde_json with "preserve_order" enabled.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Attachment: mozsearch: add "query" test coverage and new test cases