1729276 - Re-enable the use of internal link destinations in PDF output

Status: VERIFIED FIXED

(Core :: Printing: Output, enhancement)

Description

[Jonathan Kew [:jfkthame]]

When a link points to a destination within the same page, we'd like saved PDF files to use an internal destination rather than pointing back to the original site.

This was implemented in bug 1722300, but we had to disable it in bug 1725743 due to unexpected assertions/crashes.

Once https://gitlab.freedesktop.org/cairo/cairo/-/issues/508 is resolved upstream, we should import the relevant cairo patches and then re-enable this feature.

Comment 3

[nightfurysl2001]

Any chance this issue will be resolved soon? Currently on 121.0 and the issue still persists, and upstream https://gitlab.freedesktop.org/cairo/cairo/-/issues/508 has fixed it for 8 months by now.

Comment 4

[Jonathan Watt [:jwatt]]

The Cairo fixes for this are included in Cairo 1.18.0 and later.

Comment 5

[Jonathan Watt [:jwatt]]

We likely need this for the Google Gsuite team to agree to enable printing of Gsuite docs using Firefox's native printing UI (bug 1521655).

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to Jonathan Watt [:jwatt] from comment #5)

We likely need this for the Google Gsuite team to agree to enable printing of Gsuite docs using Firefox's native printing UI (bug 1521655).

Here's a testcase for this internal linking in a google doc, for what it's worth:
https://docs.google.com/document/d/1UPN8QLj-y4pdmYaivRgxea3CL-E3PeTzNXxTibnfZRM/edit?pli=1

Comment 7

[Jonathan Watt [:jwatt]]

Google has confirmed that this bug is a blocker for them.

Comment 8

[Daniel Holbert [:dholbert]]

Attachment: Bug 1729276: Re-enable the use of internal link destinations in PDF output. r?jfkthame

We previously had to disable these due to a cairo issue that they sometimes
triggered, but we're pulling in a cairo update with that issue fixed in bug
1892913, so there's no longer any reason for the pref to be disabled.

Comment 9

[Daniel Holbert [:dholbert]]

The trivial pref-flip patch here shouldn't land until we've landed a fix for bug 1892913, of course.

Comment 10

[Jonathan Kew [:jfkthame]]

Hah, yeah.... I've had exactly the same patch in my tree where I'm working on 1892913. :-) Hopefully ready soon.

Comment 11

[Daniel Holbert [:dholbert]]

(In reply to Jonathan Kew [:jfkthame] from comment #10)

Hah, yeah.... I've had exactly the same patch in my tree where I'm working on 1892913. :-) Hopefully ready soon.

Hooray!

(If you prefer, I'm happy to flag this patch as abandoned & let you take this bug & use your version if that's easier on your end, too. :) I just posted this to remove the tiniest of hurdles from the far end, in case it was helpful.)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20dfee6f93c0
Re-enable the use of internal link destinations in PDF output. r=jfkthame

Comment 13

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/20dfee6f93c0

Comment 14

[Daniel Holbert [:dholbert]]

Verified fixed in latest Nightly, using the Google Docs testcase in comment 6 (and my MoCo google account which is opted in to the native print flow for google docs).

Comment 15

[Daniel Holbert [:dholbert]]

Heads up, we may need to back this out (or adjust the pref-enabling to be Nightly-only), to avoid shipping bug 1896058 to beta. Not yet sure how easy it is to hit that breakage or how easy it is to fix, but hopefully we'll learn more during the day on Friday...

Comment 16

[Jonathan Watt [:jwatt]]

A fix landed in bug 1895872, so it looks like we're okay.