1729292 - Input of type date does not respect scroll-margin CSS

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[v.gorte]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36

Steps to reproduce:

Have a form with multiple input fields (text, number, date, etc) on a webpage with a fixed header. Since the form validation causes the invalid input field to be scrolled to (top of the viewport), the input field would be obscurred by the fixed header. Use scroll-margin-top to account for fixed header height when the form causes scrolling

Codepen minimal code example:
https://codepen.io/xxxdoTest/pen/NWgrBQM

Actual results:

scroll-margin is respected by all types of input fields, except for date input fields.

Expected results:

date input fields should respect the scroll-margin.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Scrolling and Overflow' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1729292 - Move HTMLInputElement::CreatesDateTimeWidget check into GetDateTimeBoxElement. r=smaug,sefeng

No behavior change, just drive-by cleanup (next patch adds some comments to it).

Depends on D124689

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1729292 - Honor scroll margin of host when we're scrolling to a chrome-only-access element. r=smaug,sefeng

Depends on D124690

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1f8d56ba2aa
Honor scroll margin of host when we're scrolling to a chrome-only-access element. r=smaug

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30370 for changes under testing/web-platform/tests

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c1f8d56ba2aa

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot