1729460 - Extend ESLint rule mozilla/use-services to cover defineLazyServiceGetter(s)

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

We already have an ESLint rule to avoid use of getService. It turns out we can easily extend it to handle XPCOMUtils.defineLazyServiceGetter(s) as well.

Comment 1

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8aa1f8b288bae14c66e86674441da863672041d2

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r?Mossop!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1729460 - Extend ESLint rule mozilla/use-services to cover defineLazyServiceGetter(s). r?Mossop!

Depends on D124838

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d52fde3ee0e
Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
https://hg.mozilla.org/integration/autoland/rev/5617839462be
Extend ESLint rule mozilla/use-services to cover defineLazyServiceGetter(s). r=mossop

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1729460) for causing newtab failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=AtVxlX8oQcKcJIvlrWSzDw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5617839462be213140477815a3b571a12dc39f08

Log: https://treeherder.mozilla.org/logviewer?job_id=351132767&repo=autoland
xpcshell failure: https://treeherder.mozilla.org/logviewer?job_id=351133028&repo=autoland&lineNumber=6097

Backout: https://hg.mozilla.org/integration/autoland/rev/83545c8a809117245e37ceb39f5f1deba96e16aa

Comment 6

[Mark Banner (:standard8)]

The newtab failure needed the harness updating for being able to stub the new UUID items. The Android failure was because it looks like Sinon can't stub the prompt service there (or at least not in the same way), so I've rolled it back to what it was and disabled the ESLint rule where ext-management.js uses the prompt service.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3e5a6ca39e9
Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
https://hg.mozilla.org/integration/autoland/rev/3e4201f6087a
Extend ESLint rule mozilla/use-services to cover defineLazyServiceGetter(s). r=mossop

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c3e5a6ca39e9
https://hg.mozilla.org/mozilla-central/rev/3e4201f6087a