Allow restriction characters/tokens in the middle of the search string
Categories
(Firefox :: Address Bar, enhancement, P5)
Tracking
()
People
(Reporter: prasanuv, Unassigned)
References
Details
Attachments
(1 file)
203.24 KB,
image/png
|
Details |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:92.0) Gecko/20100101 Firefox/92.0
Steps to reproduce:
Note: I'm referencing the following article w.r.t. restricting urlbar suggestions:
https://support.mozilla.org/en-US/kb/address-bar-autocomplete-firefox#w_changing-results-on-the-fly
Type "abc ? def" in urlbar.
Actual results:
Urlbar suggestions are NOT restricted to just searches.
Expected results:
Urlbar suggestions should be restricted to just searches.
Previously, typing "abc ? def" used to have the same behavior as "abc def ?", which IMO seems much more intuitive - I'd expect the user frequently wanting to tighten their searches by adding more words at the end. But current behavior seems to be that the "?" functionality breaks if there's anything typed after it.
Updated•3 years ago
|
Hi,
I was able to replicate this creating a bookmark named "abc ? def", and then typing "abc ? def" in urlbar.
It will give me search suggestions and also show a line for the bookmark with the star icon.
Is that the correct way to reproduce the bug? or perhaps you can share some screenshots of what is showing up incorrecly in your machine?
Replicated in Windows 10 64bit, Mac 10.15 and Ubuntu, using Firefox 93.0b2 beta, nightly 94.0a1 and release 92.0
Is that the correct way to reproduce the bug? or perhaps you can share some screenshots of what is showing up incorrecly in your machine?
Yes, this is the correct way to reproduce it. In addition, if there're any history matches like I do in the attached screenshot, those also incorrectly show up when I type "abc ? def".
Comment 4•3 years ago
|
||
This was a deliberate change in bug 1538050 as a fix to allow bookmark keywords to end with ?
. We may want to revisit that decision, so I'll leave this open.
Comment 5•3 years ago
|
||
I think it only adds confusion, we may have a bug (or maybe we just discussed that?) about allowing restriction tokens to be typed only at the beginning of the string. There's too many edge cases where having a token in the middle or at the end of the string breaks something.
And with Search mode it makes a lot less sense and breaks coherence of the UI.
I'd be prone to WONTFIX.
Comment 6•3 years ago
|
||
I agree.
Description
•