1729553 - test failure in devtools/client/shared/remote-debugging/adb/xpcshell/test_adb.js on apple silicon

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect)

Description

[[e-mail] (:bhearsum)]

Last week we turned on tests for Apple Silicon (OSX 11.2.3 on new Apple based hardware). We are using the simplified new test config process:
https://firefox-source-docs.mozilla.org/testing/ci-configs/index.html

As the tests are live, we are now filing bugs to help close the loop and hope to fix any issues over the next 7 weeks. As the process outlines, there are tier-3 jobs running on m-c which run these skipped tests and will expect a failure/timeout/crash- if it doesn't fail, then the job will turn orange.

Here's a link to a log that shows the test failing: https://treeherder.mozilla.org/jobs?repo=mozilla-central&tier=1%2C2%2C3&searchStr=macosx1100&revision=eac40293649628d32911c909219d514bebb8ce63&test_paths=devtools%2Fclient%2Fshared%2Fremote-debugging&selectedTaskRun=dmCjMsSzT7aLxeToJB2KsA.0

Comment 1

[[e-mail] (:bhearsum)]

Julian, can you take a look?

Comment 2

[Julian Descottes [:jdescottes]]

Thanks for the ping, I'm taking a look (keeping the ni?)

For reference, I am working on top of https://hg.mozilla.org/mozilla-central/rev/3c3519405b7bc5af3a07195b841ae71d4c649d58 since jobs on central after this one seem busted, with errors such as

Uploading error artifact public/logs from file logs with message "Could not read directory '/opt/worker/tasks/task_1631311775/logs'", reason "file-missing-on-worker" and expiry 2022-09-10T21:21:05.340Z

Comment 3

[Julian Descottes [:jdescottes]]

Ben, I am having issues running devtools/client/shared/remote-debugging/adb/xpcshell/test_adb.js on try. I removed the skip-if = apple_silicon from the ini file, but the test still doesn't get scheduled.

I can see the following line in my logs:

no tests to run using specified combination of filters: pathprefix(['devtools/client/shared/remote-debugging/adb/xpcshell/test_adb.js']), failures(apple_silicon)

Is there any other file I need to update to allow test_adb.js to run on apple_silicon?

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Julian Descottes [:jdescottes] from comment #3)

Ben, I am having issues running devtools/client/shared/remote-debugging/adb/xpcshell/test_adb.js on try. I removed the skip-if = apple_silicon from the ini file, but the test still doesn't get scheduled.

I can see the following line in my logs:

no tests to run using specified combination of filters: pathprefix(['devtools/client/shared/remote-debugging/adb/xpcshell/test_adb.js']), failures(apple_silicon)

Is there any other file I need to update to allow test_adb.js to run on apple_silicon?

Can you link me to the try push? It almost sounds like you're trying to run it in the failures job after removing the annotation (that would be wrong -- failures only runs annotated tests, you need to run it in the regular xpcshell tasks if you remove the annotation).

Comment 5

[Julian Descottes [:jdescottes]]

Here's the try push: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=8d15438a4bc492c4dccb6d4816c2f65ac5f36207&selectedTaskRun=BduYI8BoTAGw0lbWDrpaBw.0

But from what you said I just need to restore the skip if. I'll try that, thanks

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Julian Descottes [:jdescottes] from comment #5)

Here's the try push: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=8d15438a4bc492c4dccb6d4816c2f65ac5f36207&selectedTaskRun=BduYI8BoTAGw0lbWDrpaBw.0

But from what you said I just need to restore the skip if. I'll try that, thanks

Yeah, or you can add the non failures version of the Task to your existing push.

Comment 7

[Julian Descottes [:jdescottes]]

Turns out that the non failures version of the jobs contained much more logs by default than the failures one. Fix should be straightforward.

Comment 8

[Julian Descottes [:jdescottes]]

https://treeherder.mozilla.org/jobs?repo=try&revision=6fe53506e18ac8bf53da783a2152b282556d0637
(edit: also https://treeherder.mozilla.org/jobs?repo=try&revision=7a23299173d6fa17430fa28fcc6cccf777468854, not sure what is the arch string for the platform, but probably not aarch64)

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1729553 - [devtools] Fallback on x86_64 adb binaries on Darwin + arm64

We already fallback on x86 for aarch64 for adb binaries. Update this logic to also fallback on x86_64 for arm64.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35f57736301f
[devtools] Fallback on x86_64 adb binaries on Darwin + arm64 r=bomsy

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/35f57736301f