172956 - Backspace key does not return to previous page

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Will Levine]

User-Agent:       Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.2b) Gecko/20021006
Build Identifier: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.2b) Gecko/20021006

When surfing, the backspace key does not return the browser to the previous page.

Reproducible: Always

Steps to Reproduce:
1.  Open Mozilla
2.  Click on links or type address in address bar to get to another web page
3.  Press backspace

Actual Results:  
Nothing

Expected Results:  
Returned to the previous page, equivalent to hitting the back button.

Comment 1

[R.K.Aa.]

It's was decided to not implement this shortcut.
As an alternative you can use alt+left/right arrow instead. (hold in alt while
hitting left- or right-arrow)

*** This bug has been marked as a duplicate of 69981 ***

Comment 2

[R.K.Aa.]

hmm reading that bug and bug 69981 i'm not really sure what became the default
and not. Reopening.

Comment 3

[R.K.Aa.]

the copy features in Windows are useless...  i meant to write:
"reading that bug and bug 108816.."

Comment 4

[Aaron Leventhal]

Attachment: Make sure we don't PreventDefault() for backspace if not handled by typeaheadfind

Comment 5

[Aaron Leventhal]

Seeking r=/sr=

Comment 6

[:deanis74]

Comment on attachment 101947 [details] [diff] [review]
Make sure we don't PreventDefault() for backspace if not handled by typeaheadfind

>@@ -632,7 +634,7 @@
>       }
>     }
>     if (!presShell) {
>-      return;
>+      return PR_TRUE; // Backspace handled

Shouldn't you return PR_FALSE if you don't find an nsIPresShell?

>@@ -2194,6 +2198,12 @@
>     else {
>       break;
>     }
>+  }
>+
>+  PRBool isVisible;
>+  mFocusedDocSelCon->CheckVisibility(node, startRangeOffset, endFrameOffset, &isVisible);
>+  if (!isVisible) {
>+    return PR_FALSE;
>   }

Is this for another bug?

Other than those two questions, everything looks good to me.

Comment 7

[Aaron Leventhal]

Attachment: Patch with Dean's changes

Still seeking r=/sr=

Comment 8

[:deanis74]

Comment on attachment 101949 [details] [diff] [review]
Patch with Dean's changes

>@@ -632,7 +634,7 @@
>       }
>     }
>     if (!presShell) {
>-      return;
>+      return PR_FALSE; // Backspace handled
>     }

r=me if you fix that comment.  No need for a new patch.

Comment 9

[Alec Flett]

Comment on attachment 101949 [details] [diff] [review]
Patch with Dean's changes

sr=alecf

Comment 10

[Aaron Leventhal]

checked in

Comment 11

[Will Levine]

now backspace is returning to the previous page. is this supposed to happen?

Comment 12

[timeless]

yes

Comment 13

[sairuh (rarely reading bugmail)]

vrfy'd fixed on win2k, 2002.10.15.08 comm trunk.