1729602 - Allow passing constructor arguments through Rooted

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Steve Fink [:sfink] [:s:]]

As discussed in our meeting, it may be helpful for Rooted to forward its arguments to the constructor of the contained type. (I say "may" because it appears this isn't enough to make DOM bindings dictionary types Just Work with Rooted.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1729602 - Forward T constructor arguments through `Rooted<T> foo(cx, ...args...);`

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1729602 - Remove the magic cx constructor handling in `Rooted<TypeConstructibleWithCx> foo(cx);`

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1729602 - Templatize RootHolder in PersistentRooted to more closely match Rooted

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1729602 - Forward T constructor arguments through `PersistentRooted<T> foo(cx, ...args...)`

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b277bca3bfe1
Remove the magic cx constructor handling in `Rooted<TypeConstructibleWithCx> foo(cx);` r=tcampbell,jonco
https://hg.mozilla.org/integration/autoland/rev/cf7f13072e9f
Forward T constructor arguments through `Rooted<T> foo(cx, ...args...);` r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/0f06d31a9008
Templatize RootHolder in PersistentRooted to more closely match Rooted r=tcampbell,jonco
https://hg.mozilla.org/integration/autoland/rev/ba1ba9d974a4
Forward T constructor arguments through `PersistentRooted<T> foo(cx, ...args...)` r=tcampbell,jonco

Comment 6

[Marian-Vasile Laza]

Backed out 4 changesets (Bug 1729602) for causing build bustages on RootingAPI.h.
Backout link
Push with failures
Failure Log

Comment 7

[Steve Fink [:sfink] [:s:]]

Argh, I'm an idiot. I did a try push, saw this error, fixed it, then tried to land the unfixed version.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94040a0f2833
Remove the magic cx constructor handling in `Rooted<TypeConstructibleWithCx> foo(cx);` r=tcampbell,jonco
https://hg.mozilla.org/integration/autoland/rev/6e50f1b19e7a
Forward T constructor arguments through `Rooted<T> foo(cx, ...args...);` r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/65e82e9c91ed
Templatize RootHolder in PersistentRooted to more closely match Rooted r=tcampbell,jonco
https://hg.mozilla.org/integration/autoland/rev/5ccac9c66a05
Forward T constructor arguments through `PersistentRooted<T> foo(cx, ...args...)` r=tcampbell,jonco

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/94040a0f2833
https://hg.mozilla.org/mozilla-central/rev/6e50f1b19e7a
https://hg.mozilla.org/mozilla-central/rev/65e82e9c91ed
https://hg.mozilla.org/mozilla-central/rev/5ccac9c66a05