Closed Bug 1729662 Opened 2 months ago Closed 20 days ago

UNED exam page flickers / reloads infinitely (with Fission only?)

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
95 Branch
Fission Milestone MVP
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- disabled
firefox92 --- wontfix
firefox93 + wontfix
firefox94 + fixed
firefox95 --- fixed

People

(Reporter: emilio, Assigned: peterv)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached file Mozregression log.

Video incoming.

Bug 1711544 - Move decision about name resetting to the parent process if we're replacing the BC for BFCache in the parent. r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D116759

Flags: needinfo?(peterv)
Regressed by: 1711544
Attached video Video.mp4

Screencast of me reproducing the bug: http://crisal.io/tmp/1729662.webm

If you need me to dig / record it on rr / pernosco / etc let me know.

Summary: UNED exam page flickers → UNED exam page flickers / reloads infinitely

Assigning to Peter. Emilio will reproduce the bug in Pernosco for Peter.

Tracking for Fission MVP.

Assignee: nobody → peterv
Severity: -- → S3
Fission Milestone: --- → MVP
Priority: -- → P2
Summary: UNED exam page flickers / reloads infinitely → UNED exam page flickers / reloads infinitely (with Fission only?)
Flags: needinfo?(emilio)

I confirmed it only happens with fission enabled. Pernosco recording: https://pernos.co/debug/wpRE9JSC_9XQMaxnTz18-w/index.html

Flags: needinfo?(emilio)
Status: NEW → ASSIGNED
Flags: needinfo?(peterv)
Pushed by pvanderbeken@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a399e91dd5c2
UNED exam page flickers / reloads infinitely. r=smaug
Pushed by pvanderbeken@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d25df1c9e0e2
UNED exam page flickers / reloads infinitely. r=smaug

Backed out changeset d25df1c9e0e2 (Bug 1729662) for causing wpt failures in overlapping-navigations-and-traversals
Backout link: https://hg.mozilla.org/integration/autoland/rev/3c65d853629fd5bc8c9856d9f1d681dee77e1e07
Push with failures, failure log.

Pushed by pvanderbeken@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a92693fc08c7
UNED exam page flickers / reloads infinitely. r=smaug
Status: ASSIGNED → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Please nominate for Beta approval when you get a chance.

Peter, is this UNED bug fix ready for uplift to Beta 94 now?

smaug, can you please help with the uplift request?

Flags: needinfo?(bugs)

I was giving a bit of time to see if there was any fallout.

[Tracking Requested - why for this release]:

This is a fission-only bug, causing some pages to end up in a reload loop and essentially unusable. I think we should fix this for Fission MVP.

(The WPT failures were existing failures, but the fix for this bug changed the nature of the failure from the reload loop to a different bug.)

Flags: needinfo?(peterv)
Flags: needinfo?(bugs)

Comment on attachment 9242826 [details]
Bug 1729662 - UNED exam page flickers / reloads infinitely. r?smaug!

Beta/Release Uplift Approval Request

  • User impact if declined: This is a fission-only bug, causing some pages to end up in a reload loop and essentially unusable.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): This code is pretty fragile in general, but the specific change is probably not very risky. It changes the detection logic that we were using to detect reloads when Fission is enabled, but it should only cause us to stop detecting non-reloads as reloads.

The WPT failures were existing failures, but the fix for this bug changed the nature of the failures from the reload loop to a different (pre-existing) bug.

  • String changes made/needed: None
Attachment #9242826 - Flags: approval-mozilla-beta?

Comment on attachment 9242826 [details]
Bug 1729662 - UNED exam page flickers / reloads infinitely. r?smaug!

Approved for 94.0b5.

Attachment #9242826 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.