1729662 - UNED exam page flickers / reloads infinitely (with Fission only?)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Mozregression log.

Video incoming.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Bug 1711544 - Move decision about name resetting to the parent process if we're replacing the BC for BFCache in the parent. r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D116759

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Video.mp4

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Screencast of me reproducing the bug: http://crisal.io/tmp/1729662.webm

If you need me to dig / record it on rr / pernosco / etc let me know.

Comment 5

[Chris Peterson [:cpeterson]]

Assigning to Peter. Emilio will reproduce the bug in Pernosco for Peter.

Tracking for Fission MVP.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

I confirmed it only happens with fission enabled. Pernosco recording: https://pernos.co/debug/wpRE9JSC_9XQMaxnTz18-w/index.html

Comment 7

[Pascal Chevrel:pascalc]

Unfixed S3, too late for 93.

Comment 8

[Peter Van der Beken [:peterv]]

Attachment: Bug 1729662 - UNED exam page flickers / reloads infinitely. r?smaug!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a399e91dd5c2
UNED exam page flickers / reloads infinitely. r=smaug

Comment 10

[Iulian Moraru]

Backed out for causing wpt failures on cross-document-traversal-cross-document-traversal.html.

Push with failures

Failure log Linux 18.04 x64 WebRender opt
Failure log Linux 18.04 x64 WebRender debug
Failure log Linux 18.04 x64 WebRender asan opt
Failure log Windows 10 x64 2004 WebRender opt

Backout link

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d25df1c9e0e2
UNED exam page flickers / reloads infinitely. r=smaug

Comment 12

[Alexandru Michis [:malexandru]]

Backed out changeset d25df1c9e0e2 (Bug 1729662) for causing wpt failures in overlapping-navigations-and-traversals
Backout link: https://hg.mozilla.org/integration/autoland/rev/3c65d853629fd5bc8c9856d9f1d681dee77e1e07
Push with failures, failure log.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a92693fc08c7
UNED exam page flickers / reloads infinitely. r=smaug

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a92693fc08c7

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Please nominate for Beta approval when you get a chance.

Comment 16

[Chris Peterson [:cpeterson]]

Peter, is this UNED bug fix ready for uplift to Beta 94 now?

Comment 17

[Ryan VanderMeulen [:RyanVM]]

smaug, can you please help with the uplift request?

Comment 18

[Peter Van der Beken [:peterv]]

I was giving a bit of time to see if there was any fallout.

[Tracking Requested - why for this release]:

This is a fission-only bug, causing some pages to end up in a reload loop and essentially unusable. I think we should fix this for Fission MVP.

(The WPT failures were existing failures, but the fix for this bug changed the nature of the failure from the reload loop to a different bug.)

Comment 19

[Peter Van der Beken [:peterv]]

Comment on attachment 9242826 [details]
Bug 1729662 - UNED exam page flickers / reloads infinitely. r?smaug!

Beta/Release Uplift Approval Request

• User impact if declined: This is a fission-only bug, causing some pages to end up in a reload loop and essentially unusable.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This code is pretty fragile in general, but the specific change is probably not very risky. It changes the detection logic that we were using to detect reloads when Fission is enabled, but it should only cause us to stop detecting non-reloads as reloads.

The WPT failures were existing failures, but the fix for this bug changed the nature of the failures from the reload loop to a different (pre-existing) bug.

• String changes made/needed: None

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9242826 [details]
Bug 1729662 - UNED exam page flickers / reloads infinitely. r?smaug!

Approved for 94.0b5.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2dbc6f0d1314