1729709 - [Wayland] Avoid move-to-rect calls when popup size changes but it still fits main window bounds

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Move-to-rect is an expensive call. When popup size changes but it still fits main window bounds we can just resize it without whole hide/show circus here.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1729709 [Wayland] Avoid move-to-rect calls when popup size changes but it still fits main window bounds, r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/101c85628109
[Wayland] Avoid move-to-rect calls when popup size changes but it still fits main window bounds, r=emilio

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/101c85628109

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Please revert this bug for Firefox 94. It causes regressions (Bug 1733620) which we can't backport to FF94.
Thanks.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #4)

Please revert this bug for Firefox 94. It causes regressions (Bug 1733620) which we can't backport to FF94.
Thanks.

Needinfoing Ryan as release manager for Firefox 94. Sheriffs are only in charge of backouts on autoland and central.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

We already built the RC for Fx94. I'll keep it on the radar for a respin but no promises at this point....

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for 94rc2.
https://hg.mozilla.org/releases/mozilla-release/rev/21a4eaae720e