1729751 - error[E0599]: no variant or associated item named `Wayland` found for enum `RawWindowHandle` in the current scope

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Solaris (no Wayland) build fails with:

 8:54.16    Compiling fog v0.1.0 (/builds/psumbera/mozilla-central-build/toolkit/components/glean/api)
 8:57.62 error[E0599]: no variant or associated item named `Wayland` found for enum `RawWindowHandle` in the current scope
 8:57.62    --> /builds/psumbera/mozilla-central-build/third_party/rust/wgpu-hal/src/gles/egl.rs:600:18
 8:57.62     |
 8:57.62 600 |             Rwh::Wayland(handle) => {
 8:57.62     |                  ^^^^^^^ variant or associated item not found in `RawWindowHandle`
 8:57.66 error[E0599]: no variant or associated item named `Wayland` found for enum `RawWindowHandle` in the current scope
 8:57.66    --> /builds/psumbera/mozilla-central-build/third_party/rust/wgpu-hal/src/gles/egl.rs:848:26
 8:57.66     |
 8:57.66 848 |                     Rwh::Wayland(handle) => {
 8:57.66     |                          ^^^^^^^ variant or associated item not found in `RawWindowHandle`
 8:58.97 error: aborting due to 2 previous errors
 8:58.97 For more information about this error, try `rustc --explain E0599`.
 8:59.04 error: could not compile `wgpu-hal`

The first bad revision is:
changeset: 590947:ef5dc3e04e5f
user: Dzmitry Malyshau <[e-mail]>
date: Fri Sep 03 09:52:08 2021 -0700
description:
Bug 1726626 - Move gfx/wgpu into a 3rd party dependency r=jgilbert,bholley

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Dzmitry Malyshau [:kvark]]

Apologies! Petr previously fixed this on Vulkan, but now we are exposing GLES3 as well on Linux (in a limited form), so the bug slipped in there. I'm taking care of it.

Comment 3

[Petr Sumbera]

With following patch I'm able to build it again:

--- a/third_party/rust/wgpu-hal/src/gles/egl.rs Sat Sep 04 12:38:27 2021 +0300
+++ b/third_party/rust/wgpu-hal/src/gles/egl.rs Wed Sep 08 11:03:07 2021 -0700
@@ -596,7 +596,7 @@
                     return Err(crate::InstanceError);
                 }
             }
-            #[cfg(not(any(target_os = "android", target_os = "macos")))]
+            #[cfg(not(any(target_os = "android", target_os = "macos", target_os = "solaris")))]
             Rwh::Wayland(handle) => {
                 /* Wayland displays are not sharable between surfaces so if the
                  * surface we receive from this handle is from a different
@@ -844,7 +844,7 @@
                     }
                     #[cfg(target_os = "android")]
                     Rwh::Android(handle) => handle.a_native_window,
-                    #[cfg(not(any(target_os = "android", target_os = "macos")))]
+                    #[cfg(not(any(target_os = "android", target_os = "macos", target_os = "solaris")))]
                     Rwh::Wayland(handle) => {
                         let library = self.wsi_library.as_ref().expect("unsupported window");
                         let wl_egl_window_create: libloading::Symbol<WlEglWindowCreateFun> =

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1726626

Comment 5

[Dzmitry Malyshau [:kvark]]

Attachment: Update wgpu and ron 3rd parties

Brings a few important fixes:

• better WGSL support
• Solaris build (1729751)
• crash in "_MTLCommandEncoder dealloc" (1729648)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dfd91f9ba77
Update wgpu and ron 3rd parties r=jimb

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8dfd91f9ba77

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kvark, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Dzmitry Malyshau [:kvark]]

This is a fairly big patch, which doesn't even do anything on Beta (other than fixing the build on Solaris).
Petr, how do you generally use FF on Solaris? Do you package the builds manually, apply certain patches, etc, or do you just expect it to work out of the box?

Comment 10

[Dzmitry Malyshau [:kvark]]

Attachment: 0001-Fix-Rust-config-checks-for-Solaris-in-wgpu-GL-backen.patch

Approval Request Comment
[Feature/Bug causing the regression]: Enabling OpenGL backend for WebGPU
[User impact if declined]: Solaris build requires a patch.
[Is this code covered by automated tests?]: No, we don't CI check Solaris.
[Has the fix been verified in Nightly?]: Nightly landed a larger change, including these lines.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial change
[String changes made/needed]:

Note: launched a try push just for sanity:
https://treeherder.mozilla.org/jobs?repo=try&revision=794d6ee8af7b7c96c1ca129ca6096d7859d685a0

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9241887 [details] [diff] [review]
0001-Fix-Rust-config-checks-for-Solaris-in-wgpu-GL-backen.patch

It doesn't affect our own builds, approved for 93 beta 8, thanks.

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d89b3767a0bb